DNS-Hosts: appending matched-results again#4702
Merged
Conversation
patterniha
changed the title
patterniha
changed the title
Member
|
Can you do a proper |
Collaborator
Author
No, it should not be reverted, the number-1 in #4673 is OK. |
Member
|
Ok I see it now. Thanks! |
Collaborator
Author
Done: #4706 In fact, if I knew I could solve "json.Unmarshal" problem so soon, I wouldn't have opened this PR at all |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unmarshalling json in golang will not respect order.
So, sorting
h.matchers.Match(domain)in #4673 is useless and the order of the results is still messed up, Becausejson.Unmarshalmessed up the order of domains at the very beginning.So, I temporarily reverted this to the previous state (appending matched-results).
///
I need to change
json.Unmarshalfor hosts to completely fix this issue.