Skip to content

Comments

Transport: Remove DomainSocket#3755

Merged
mmmray merged 5 commits intoXTLS:mainfrom
mmmray:remove-domainsocket
Sep 3, 2024
Merged

Transport: Remove DomainSocket#3755
mmmray merged 5 commits intoXTLS:mainfrom
mmmray:remove-domainsocket

Conversation

@mmmray
Copy link
Contributor

@mmmray mmmray commented Sep 2, 2024

As requested. If you need this, why not use the corresponding sockopt?

@Fangliding
Copy link
Member

Just to mention, last time we break domainsocket, we received many complains.

@mmmray
Copy link
Contributor Author

mmmray commented Sep 2, 2024

was it about the transport or the sockopt? I think those don't share any code with each other. Couldn't find anything in the issuetracker...

@RPRX
Copy link
Member

RPRX commented Sep 3, 2024

@mmmray Conflict 了

@RPRX
Copy link
Member

RPRX commented Sep 3, 2024

还有正确写法不是 sockopt,而是写在入站的 listen 处:https://xtls.github.io/config/inbound.html

@RPRX
Copy link
Member

RPRX commented Sep 3, 2024

还有正确写法不是 sockopt,而是写在入站的 listen 处:https://xtls.github.io/config/inbound.html

@Fangliding 这个文档的“传输方式可选...”改成“不可选 mKCP 等基于 UDP 的传输方式”

@Fangliding
Copy link
Member

还有正确写法不是 sockopt,而是写在入站的 listen 处:https://xtls.github.io/config/inbound.html

@Fangliding 这个文档的“传输方式可选...”改成“不可选 mKCP 等基于 UDP 的传输方式”

好了 还顺便移出了ds传输和global transport

@RPRX
Copy link
Member

RPRX commented Sep 3, 2024

@Fangliding 看起来 DS 和 QUIC 的页面都还活得好好的,我觉得特性描述有一些可取之处,转移到 listen 和 SplitHTTP H3 吧

@mmmray mmmray changed the title Remove domainsocket transport Transport: Remove domainsocket Sep 3, 2024
@mmmray mmmray merged commit 59b350f into XTLS:main Sep 3, 2024
@mmmray mmmray deleted the remove-domainsocket branch September 3, 2024 10:17
@RPRX
Copy link
Member

RPRX commented Sep 3, 2024

麻烦 force-push 掉,我需要修改 commit message,以后 PR 我来合并

@mmmray
Copy link
Contributor Author

mmmray commented Sep 3, 2024

The PR has been removed from master.

@mmmray mmmray restored the remove-domainsocket branch September 3, 2024 11:25
@RPRX RPRX changed the title Transport: Remove domainsocket Transport: Remove DomainSocket Sep 3, 2024
RPRX pushed a commit that referenced this pull request Sep 3, 2024
leninalive pushed a commit to amnezia-vpn/amnezia-xray-core that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants