SplitHTTP server: Only "ok" to older clients#3671
Merged
Conversation
Member
|
VLESS padding 永远无法取代 GET response 的 header padding，因为不能保证经过 middlebox 后它们仍然黏在一起 |
Member
|
话说这个 PR 要不要改成检测到没有任何 querystring 才发 |
Member
|
Contributor
Author
there are some people who randomly add (by the way, why is |
Member
Because /ed1024/xxx or xxx/ed1024 doesn't seem like a good choice |
leninalive
pushed a commit
to amnezia-vpn/amnezia-xray-core
that referenced
this pull request
Oct 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3643 (comment)
It makes sense. In earlier discussions of breaking changes, we assumed the server updates much faster than the client. But this is easy to do.
Note:
responseFlusher.Flush()could also be conditional. It would mean that HTTP response headers are only written when the first VLESS response byte is written. For some CDN this is already the case. I am not sure what is preferred from a padding perspective. I guess technically response X-Padding can be removed ifresponseFlusher.Flush()is removed, and VLESS brings its own padding in the future. Anyway, I don't want to change it right now, because I am not sure if it triggers different timeout settings in the CDN. It can be changed later, it's not a breaking change.