SpanOption DisableQuery#26
Conversation
DisableQuery when set to true, will suppress attribute of key db.statement on spans.
this commit adds a step check on every span which uses db.statement attribute. in case SpanOption.DisableQuery is set true, the attribute is not set.
|
Hi @XSAM this time I am trying to disable the query itself. I wonder if would make sense to set the value with something like "-" instead of not sending it. wdyt ? |
I think not sending the value is make sense to me. You can check the example value from the specification. |
XSAM
left a comment
XSAM
left a comment
There was a problem hiding this comment.
Looks good overall. Please update CHANGELOG.md and run make precommit before commit.
updates the changelog adding new feature option for SpanOption + fix linting.
Codecov Report
@@ Coverage Diff @@
## main #26 +/- ##
=======================================
- Coverage 82.3% 81.6% -0.8%
=======================================
Files 11 11
Lines 311 299 -12
=======================================
- Hits 256 244 -12
Misses 45 45
Partials 10 10
Continue to review full report at Codecov.
|
Co-authored-by: Sam Xie <[email protected]>
Co-authored-by: Sam Xie <[email protected]>
XSAM
left a comment
XSAM
left a comment
There was a problem hiding this comment.
@wesleyvicthor LGTM. Thanks for your contribution.
2 participants
Hi, this PR attempts to cover the DisableQuery functionality, this time as opposed #25, it makes only the attribute not set.
It tries to cover the expected functionality by #22