fix: Prevents overwriting a bool value in an invariant by Tapanito · Pull Request #6609 · XRPLF/rippled

Tapanito · 2026-03-20T16:46:08Z

This PR fixes a bug where boolean results could be overwritten by multiple calls to visitEntry.

Backport for 3.1.x: #6961.

High Level Overview of Change

Context of Change

API Impact

Public API: New feature (new methods and/or new fields)
Public API: Breaking change (in general, breaking changes should only impact the next api_version)
libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
Peer protocol change (must be backward compatible or bump the peer protocol version)

mvadari

This needs an amendment

codecov · 2026-03-20T17:06:20Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.1%. Comparing base (6407f0f) to head (72dc6af).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

@@            Coverage Diff            @@
##           develop   #6609     +/-   ##
=========================================
- Coverage     82.1%   82.1%   -0.0%     
=========================================
  Files         1010    1010             
  Lines        76048   76064     +16     
  Branches      7384    7378      -6     
=========================================
+ Hits         62413   62424     +11     
- Misses       13635   13640      +5

Files with missing lines	Coverage Δ
include/xrpl/protocol/Rules.h	`100.0% <ø> (ø)`
src/libxrpl/protocol/Rules.cpp	`98.0% <100.0%> (+0.2%)`	⬆️
src/libxrpl/tx/invariants/InvariantCheck.cpp	`95.7% <100.0%> (+0.1%)`	⬆️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

bthomee · 2026-03-20T17:06:38Z

/ai-review

xrplf-ai-reviewer

No issues.

Review by Claude Opus 4.6 · Prompt: V12

Three invariant checks used = instead of |= to accumulate their boolean flag across multiple visited entries. A later "good" entry could overwrite a violation detected by an earlier "bad" entry. Gate the corrected |= behavior behind fixInvariantOverwrite to preserve pre-amendment consensus. Each affected class tracks both the fixed (|=) and legacy (=) values; finalize picks which to use based on the amendment. Affected invariants: - NoZeroEscrow (bad_ for MPT locked vs outstanding) - NoXRPTrustLines (xrpTrustLine_) - NoDeepFreezeTrustLinesWithoutFreeze (deepFreezeWithoutFreeze_)

Tapanito · 2026-03-21T13:37:42Z

/ai-review

xrplf-ai-reviewer

Invariant detection vulnerable to boolean flag overwrite in legacy mode

Review by Claude Opus 4.6 · Prompt: V12

github-actions · 2026-03-26T00:44:28Z

This PR has conflicts, please resolve them in order for the PR to be reviewed.

…-bugfix

github-actions · 2026-03-31T08:59:20Z

All conflicts have been resolved. Assigned reviewers can now start or resume their review.

xrplf-ai-reviewer · 2026-03-31T09:07:46Z

⚠️ Review Error — The automated review failed to complete. Please re-trigger with /ai-review.

Error: Bad response code, expected 200: {'status_code': 400, 'headers': {':exception-type': 'internalServerException', ':content-type': 'application/json', ':message-type': 'exception'}, 'body': b'{"message"

Review by Claude Opus 4.6 · Prompt: v12

github-actions · 2026-03-31T17:50:32Z

This PR has conflicts, please resolve them in order for the PR to be reviewed.

…-bugfix

…bugfix * XRPLF/develop: chore: Enable clang-tidy modernize checks (6975) ci: Upload clang-tidy git diff (6983) fix: Add rounding to Vault invariants (6217) (6955) fix: Disallow MPTClearRequireAuth if is set (6712)

github-actions · 2026-04-21T18:36:19Z

All conflicts have been resolved. Assigned reviewers can now start or resume their review.

xrplf-ai-reviewer

No issues.

Review by Claude Opus 4.6 · Prompt: V15

Co-authored-by: Vito <[email protected]>

xrplf-ai-reviewer

No issues.

Review by Claude Opus 4.6 · Prompt: V15

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

bthomee · 2026-04-29T19:34:06Z

@Tapanito please take a look at the Copilot review. If something needs changing, we should change that too in the staging branch. Otherwise, if Copilot is wrong please resolve the comment and indicate that this PR is ready to merge.

Both the NoXRPTrustLines and NoDeepFreeze regression tests constructed a pair of keylets, hash-sorted them, and inserted two SLEs in that order - duplicating the ordering logic. Extract this into a local insertOrderedTrustLinePair helper so each test only configures what distinguishes its bad/good entries. Also fixes the NoDeepFreeze test, which previously chose between two unrelated key pairings (key_A2_usd/key_A3_eur vs key_A3_usd/key_A2_eur) based on a comparison only valid for the first pairing - the bad-first visit ordering the test relied on was not actually guaranteed.

xrplf-ai-reviewer

No issues.

Review by Claude Opus 4.6 · Prompt: V15

xrplf-ai-reviewer

No issues.

Review by Claude Opus 4.6 · Prompt: V15

xrplf-ai-reviewer

No issues.

Review by Claude Opus 4.6 · Prompt: V15

xrplf-ai-reviewer

No issues.

Review by Claude Opus 4.6 · Prompt: V15

Co-authored-by: Ed Hennis <[email protected]>

fix: prevents overwritting a bool value in an invariant

90f9a3f

Tapanito requested review from bthomee and mvadari March 20, 2026 16:46

Merge branch 'develop' into tapanito/invariant-bugfix

d08e7b4

Tapanito changed the title ~~fix: prevents overwritting a bool value in an invariant~~ fix: Prevents overwritting a bool value in an invariant Mar 20, 2026

mvadari reviewed Mar 20, 2026

View reviewed changes

mvadari added the Amendment label Mar 20, 2026

xrplf-ai-reviewer Bot approved these changes Mar 20, 2026

View reviewed changes

Tapanito changed the title ~~fix: Prevents overwritting a bool value in an invariant~~ fix: Prevents overwriting a bool value in an invariant Mar 21, 2026

Tapanito requested a review from mvadari March 21, 2026 13:37

xrplf-ai-reviewer Bot reviewed Mar 21, 2026

View reviewed changes

mvadari added the AI Triage Bugs and fixes that have been triaged via AI initiatives label Mar 24, 2026

github-actions Bot added the PR: has conflicts label Mar 26, 2026

bthomee reviewed Mar 30, 2026

View reviewed changes

Comment thread src/libxrpl/tx/invariants/InvariantCheck.cpp Outdated

Comment thread src/libxrpl/tx/invariants/InvariantCheck.cpp Outdated

Tapanito added 2 commits March 31, 2026 10:17

Merge remote-tracking branch 'origin/develop' into tapanito/invariant…

82266a3

…-bugfix

address review comments

f1d0333

github-actions Bot removed the PR: has conflicts label Mar 31, 2026

bthomee reviewed Mar 31, 2026

View reviewed changes

Comment thread src/libxrpl/tx/invariants/InvariantCheck.cpp Outdated

Comment thread src/test/app/Invariants_test.cpp Outdated

Comment thread src/test/app/Invariants_test.cpp Outdated

fix: remove enabled amendments from tests

baeaf09

github-actions Bot added the PR: has conflicts label Mar 31, 2026

Merge remote-tracking branch 'origin/develop' into tapanito/invariant…

e3a3b77

…-bugfix

github-actions Bot removed the PR: has conflicts label Apr 1, 2026

ximinez added 2 commits April 21, 2026 14:23

fixup! AI review feedback: mark header function as inline

8fdd482

github-actions Bot removed the PR: has conflicts label Apr 21, 2026

xrplf-ai-reviewer Bot approved these changes Apr 21, 2026

View reviewed changes

ximinez added a commit that referenced this pull request Apr 22, 2026

fix: Prevents overwritting a bool value in an invariant (#6609) (#6961)

2794a75

Co-authored-by: Vito <[email protected]>

Merge branch 'develop' into tapanito/invariant-bugfix

adfa47e

xrplf-ai-reviewer Bot approved these changes Apr 27, 2026

View reviewed changes

bthomee requested a review from Copilot April 29, 2026 19:22

Copilot started reviewing on behalf of bthomee April 29, 2026 19:23 View session

mvadari approved these changes Apr 29, 2026

View reviewed changes

Copilot AI reviewed Apr 29, 2026

View reviewed changes

Comment thread src/test/app/Invariants_test.cpp Outdated

xrplf-ai-reviewer Bot approved these changes Apr 30, 2026

View reviewed changes

resotre include

263d3a7

xrplf-ai-reviewer Bot approved these changes Apr 30, 2026

View reviewed changes

Merge branch 'develop' into tapanito/invariant-bugfix

3b58855

xrplf-ai-reviewer Bot approved these changes Apr 30, 2026

View reviewed changes

bthomee approved these changes Apr 30, 2026

View reviewed changes

addresses review feedback

72dc6af

Tapanito added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Apr 30, 2026

xrplf-ai-reviewer Bot approved these changes Apr 30, 2026

View reviewed changes

bthomee enabled auto-merge April 30, 2026 12:47

bthomee added this pull request to the merge queue Apr 30, 2026

Merged via the queue into develop with commit 31180f9 Apr 30, 2026
3 checks passed

bthomee deleted the tapanito/invariant-bugfix branch April 30, 2026 13:28

marek-foss-neti pushed a commit to marek-foss-neti/rippled that referenced this pull request May 5, 2026

fix: Prevents overwriting a bool value in an invariant (XRPLF#6609)

321b867

Co-authored-by: Ed Hennis <[email protected]>

beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026

fix: Prevents overwriting a bool value in an invariant (XRPLF#6609)

515ee5d

Co-authored-by: Ed Hennis <[email protected]>

Uh oh!

Conversation

Tapanito commented Mar 20, 2026 • edited by ximinez Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

High Level Overview of Change

Context of Change

API Impact

Uh oh!

mvadari left a comment

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bthomee commented Mar 20, 2026

Uh oh!

xrplf-ai-reviewer Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Tapanito commented Mar 21, 2026

Uh oh!

xrplf-ai-reviewer Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Mar 26, 2026

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Mar 31, 2026

Uh oh!

xrplf-ai-reviewer Bot commented Mar 31, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Mar 31, 2026

Uh oh!

github-actions Bot commented Apr 21, 2026

Uh oh!

xrplf-ai-reviewer Bot left a comment

Choose a reason for hiding this comment

Uh oh!

xrplf-ai-reviewer Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

bthomee commented Apr 29, 2026

Uh oh!

xrplf-ai-reviewer Bot left a comment

Choose a reason for hiding this comment

Uh oh!

xrplf-ai-reviewer Bot left a comment

Choose a reason for hiding this comment

Uh oh!

xrplf-ai-reviewer Bot left a comment

Choose a reason for hiding this comment

Uh oh!

xrplf-ai-reviewer Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Tapanito commented Mar 20, 2026 •

edited by ximinez

Loading

codecov Bot commented Mar 20, 2026 •

edited

Loading