Skip to content

PR from pytorch/ignite#3

Merged
WrRan merged 18 commits intoWrRan:masterfrom
pytorch:master
Jul 17, 2020
Merged

PR from pytorch/ignite#3
WrRan merged 18 commits intoWrRan:masterfrom
pytorch:master

Conversation

@WrRan
Copy link
Copy Markdown
Owner

@WrRan WrRan commented Jul 17, 2020

No description provided.

WrRan and others added 18 commits July 8, 2020 09:07
…1186)

* ValueError -> TypeError

* NotImplementedError -> NotImplemented

* rollback ignite/engine/events [raise NotImplementedError]

* fix misuses of exceptions in ignite/contrib/handlers/custom_events.py

* remove period in exceptions

* refactor corresponding unit tests
* ValueError -> TypeError

* NotImplementedError -> NotImplemented

* fix misuses of exceptions in ignite/contrib/engines/common.py

* rollback ignite/engine/events [raise NotImplementedError]

Co-authored-by: Sylvain Desroziers <[email protected]>
Co-authored-by: vfdev <[email protected]>
- we can better test new coming comp models

Co-authored-by: Sylvain Desroziers <[email protected]>
* ValueError -> TypeError

* NotImplementedError -> NotImplemented

* rollback ignite/engine/events [raise NotImplementedError]

* fix misuses of exceptions in ignite/contrib/handlers/lr_finder.py

* refactor corresponding unit tests

* fix typo

Co-authored-by: Desroziers <[email protected]>
Co-authored-by: Sylvain Desroziers <[email protected]>
Co-authored-by: vfdev <[email protected]>
…1188)

* ValueError -> TypeError

* NotImplementedError -> NotImplemented

* rollback ignite/engine/events [raise NotImplementedError]

* fix misuses of exceptions in ignite/contrib/handlers/mlflow_logger.py & refactor corresponding unit tests

Co-authored-by: Sylvain Desroziers <[email protected]>
Co-authored-by: vfdev <[email protected]>
…1189)

* ValueError -> TypeError

* NotImplementedError -> NotImplemented

* rollback ignite/engine/events [raise NotImplementedError]

* fix misuses of exceptions in ignite/contrib/handlers/neptune_logger.py & refactor corresponding unit tests

Co-authored-by: Sylvain Desroziers <[email protected]>
Co-authored-by: vfdev <[email protected]>
* Update README.md

We are adding a disclaimer to all non-FB led repos in the PyTorch github org. Let me know if you have any concerns. Thanks!

* Update README.md

Co-authored-by: vfdev <[email protected]>
* fix for distributed proxy sampler padding

* fixed formatting
* update timers including fired handlers ones

* autopep8 fix

* fix measurement and add test

* rename fire_start_time to handlers_start_time

Co-authored-by: Desroziers <[email protected]>
Co-authored-by: AutoPEP8 <>
* Fixes #1124

- Trains logger can log torch vectors

* [WIP] Fixes issue with exp_trackin
- improved configs
- training script

* [WIP] Added explicit TrainsSaver setup

* Updated training script

* Fixed formatting

* Fixed bad merging

* Added missing rank dispatch for the progressbar
* Custom filename pattern for saving checkpoints

* The suffix check be confused when adding name initially to the dict

* The filename prefix was updated which is not necessary was reverted

* The default filename pattern attribute was set instead of the `_filename_pattern`

* The redundant filename pattern to make filename was ugly, changed to something much more simple.

* The filename pattern implementation changed to have a new way to be initialized via an additional argument.

* - The extension given in the class has a dot infront of it, this can cause issues when having the latest filename pattern. have fixed it by assigning only the extension value not the dot
- The docsstring was updated to latest changes
- The assignment of name to filename pattern was missing

* The tests for checking the checkpoint filenames when a custom filename pattern is given.

* The formatting issue fixed

* - Added a function to get the filename pattern for the default to make it much more readable.
- Updated the current checkpoint __call__ to make filename based on the new function which has introduced
- Updated test_checkpoint_filename_pattern to have the exact values instead have a function.
- Updated a test case where it was failing due to the latest changes in a checkpoint __call__.

* - The _get_filename_pattern function updated to public and static setup_filename_pattern
- The setup_filename_pattern now takes updated arguments of with_score, with_score_name and with_global_step_transform

* The dostring and the static setup_filename_pattern were updated

- The docstring was updated with the filename_pattern also added a example
  for this as well.
- The static function `setup_filename_pattern` to get the default filename pattern
  of a checkpoint didn't have a proper typing. Have updated accordingly
- The `setup_filename_pattern` function accepted the custom filename pattern
  which was not required. Have updated this as well not to accept the custom
  filename pattern.

* The tests for the static function `Checkpoint.setup_filename_pattern`.

* The Docstring for setup_filename_pattern added and have updated the tests for this function.
- The docstring for the function used for making the default filename pattern for checkpoints is added.
- Added a new argument for filename prefix (`with_prefix`).
- The tests for the update is added

* Code clean up to have much more meaning to the code

* Simplified the code and tests

* fix quotes

* Revert "fix quotes"

This reverts commit 1b8d8e1.

Co-authored-by: Sylvain Desroziers <[email protected]>
Co-authored-by: vfdev <[email protected]>
* Fixes #1174
- Updated docs
- auto_model puts params on device if they are not the device

* - Updated docs

* Update auto.py
* Minor optimization for idist.get_*

* Set overhead threshold to 1.9

* Keep only test_idist_methods_overhead_nccl

* Removed _sync_model_wrapper to implicitly check if we need to sync model
This also reduces time of idist.get_* method calls vs native calls

* Update test_native.py

* autopep8 fix

* Update test_native.py

Co-authored-by: AutoPEP8 <>
Co-authored-by: Sylvain Desroziers <[email protected]>
* Fixes #1199
- Updated code to propagate spawn kwargs
- start_method is fork by default

* Fixed bad syntax
* Fixes #1198
- put CM to cpu before converting to numpy
- removed manual recall computation, put into CM definition

* Explicit CM compute by all proc and logging by 0 rank proc
* Fixed wrong IoU computation

* use black to fix lint check error

* Updated training code:
- added custom_event_filter to log images less frequently
- split events to avoid running validation twice in the end of the training

* Fixed formatting

Co-authored-by: Desroziers <[email protected]>
@WrRan WrRan merged commit 00c7970 into WrRan:master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants