|
| 1 | +import 'dart:convert'; |
| 2 | +import 'package:dependency_validator/src/dependency_validator.dart'; |
| 3 | +import 'package:pub_semver/pub_semver.dart'; |
| 4 | +import 'package:pubspec_parse/pubspec_parse.dart'; |
| 5 | +import 'package:test/test.dart'; |
| 6 | +import 'package:test_descriptor/test_descriptor.dart' as d; |
| 7 | + |
| 8 | +import 'pubspec_to_json.dart'; |
| 9 | +import 'utils.dart'; |
| 10 | + |
| 11 | +void main() => group('Nested packages', () { |
| 12 | + initLogs(); |
| 13 | + |
| 14 | + test('ignores dependencies used only in nested packages', () async { |
| 15 | + final rootPubspec = Pubspec( |
| 16 | + 'code_assets', |
| 17 | + environment: requireDart36, |
| 18 | + dependencies: { |
| 19 | + 'http': HostedDependency(version: VersionConstraint.any), |
| 20 | + }, |
| 21 | + ); |
| 22 | + |
| 23 | + final nestedPubspec = Pubspec( |
| 24 | + 'host_name', |
| 25 | + environment: requireDart36, |
| 26 | + devDependencies: { |
| 27 | + 'ffigen': HostedDependency(version: VersionConstraint.any), |
| 28 | + }, |
| 29 | + ); |
| 30 | + |
| 31 | + final dir = d.dir('code_assets', [ |
| 32 | + d.file('pubspec.yaml', jsonEncode(rootPubspec.toJson())), |
| 33 | + d.dir('lib', [ |
| 34 | + d.file('code_assets.dart', 'import "package:http/http.dart";'), |
| 35 | + ]), |
| 36 | + d.dir('example', [ |
| 37 | + d.dir('host_name', [ |
| 38 | + d.file('pubspec.yaml', jsonEncode(nestedPubspec.toJson())), |
| 39 | + d.dir('tool', [ |
| 40 | + d.file('ffigen.dart', 'import "package:ffigen/ffigen.dart";'), |
| 41 | + ]), |
| 42 | + d.dir('lib', [ |
| 43 | + d.file( |
| 44 | + 'host_name.dart', 'import "package:archive/archive.dart";'), |
| 45 | + ]), |
| 46 | + ]), |
| 47 | + ]), |
| 48 | + ]); |
| 49 | + |
| 50 | + await dir.create(); |
| 51 | + final result = await checkPackage(root: '${d.sandbox}/code_assets'); |
| 52 | + expect(result, isTrue); |
| 53 | + }); |
| 54 | + |
| 55 | + test( |
| 56 | + 'fails when root package itself has undeclared dependencies outside nested packages', |
| 57 | + () async { |
| 58 | + final rootPubspec = Pubspec( |
| 59 | + 'code_assets', |
| 60 | + environment: requireDart36, |
| 61 | + dependencies: {}, |
| 62 | + ); |
| 63 | + |
| 64 | + final nestedPubspec = Pubspec( |
| 65 | + 'host_name', |
| 66 | + environment: requireDart36, |
| 67 | + devDependencies: { |
| 68 | + 'ffigen': HostedDependency(version: VersionConstraint.any), |
| 69 | + }, |
| 70 | + ); |
| 71 | + |
| 72 | + final dir = d.dir('code_assets_with_issue', [ |
| 73 | + d.file('pubspec.yaml', jsonEncode(rootPubspec.toJson())), |
| 74 | + d.dir('tool', [ |
| 75 | + // Undeclared dependency in root package's own tool dir |
| 76 | + d.file('root_tool.dart', 'import "package:meta/meta.dart";'), |
| 77 | + ]), |
| 78 | + d.dir('example', [ |
| 79 | + d.dir('host_name', [ |
| 80 | + d.file('pubspec.yaml', jsonEncode(nestedPubspec.toJson())), |
| 81 | + d.dir('tool', [ |
| 82 | + d.file('ffigen.dart', 'import "package:ffigen/ffigen.dart";'), |
| 83 | + ]), |
| 84 | + ]), |
| 85 | + ]), |
| 86 | + ]); |
| 87 | + |
| 88 | + await dir.create(); |
| 89 | + final result = |
| 90 | + await checkPackage(root: '${d.sandbox}/code_assets_with_issue'); |
| 91 | + expect(result, isFalse); |
| 92 | + }); |
| 93 | + |
| 94 | + test('ignores deeply nested packages', () async { |
| 95 | + final rootPubspec = Pubspec( |
| 96 | + 'root_pkg', |
| 97 | + environment: requireDart36, |
| 98 | + ); |
| 99 | + |
| 100 | + final deeplyNestedPubspec = Pubspec( |
| 101 | + 'deep_pkg', |
| 102 | + environment: requireDart36, |
| 103 | + ); |
| 104 | + |
| 105 | + final dir = d.dir('root_pkg', [ |
| 106 | + d.file('pubspec.yaml', jsonEncode(rootPubspec.toJson())), |
| 107 | + d.dir('example', [ |
| 108 | + d.dir('nested', [ |
| 109 | + d.dir('deep', [ |
| 110 | + d.file( |
| 111 | + 'pubspec.yaml', jsonEncode(deeplyNestedPubspec.toJson())), |
| 112 | + d.dir('lib', [ |
| 113 | + d.file('deep.dart', 'import "package:meta/meta.dart";'), |
| 114 | + ]), |
| 115 | + ]), |
| 116 | + ]), |
| 117 | + ]), |
| 118 | + ]); |
| 119 | + |
| 120 | + await dir.create(); |
| 121 | + final result = await checkPackage(root: '${d.sandbox}/root_pkg'); |
| 122 | + expect(result, isTrue); |
| 123 | + }); |
| 124 | + |
| 125 | + test('ignores SCSS and Less files in nested packages', () async { |
| 126 | + final rootPubspec = Pubspec( |
| 127 | + 'web_pkg', |
| 128 | + environment: requireDart36, |
| 129 | + ); |
| 130 | + |
| 131 | + final nestedPubspec = Pubspec( |
| 132 | + 'nested_web_pkg', |
| 133 | + environment: requireDart36, |
| 134 | + ); |
| 135 | + |
| 136 | + final dir = d.dir('web_pkg', [ |
| 137 | + d.file('pubspec.yaml', jsonEncode(rootPubspec.toJson())), |
| 138 | + d.dir('example', [ |
| 139 | + d.dir('nested_web', [ |
| 140 | + d.file('pubspec.yaml', jsonEncode(nestedPubspec.toJson())), |
| 141 | + d.dir('web', [ |
| 142 | + d.file( |
| 143 | + 'style.scss', '@import "package:foo_styles/style.scss";'), |
| 144 | + d.file( |
| 145 | + 'style.less', '@import "packages/bar_styles/style.less";'), |
| 146 | + ]), |
| 147 | + ]), |
| 148 | + ]), |
| 149 | + ]); |
| 150 | + |
| 151 | + await dir.create(); |
| 152 | + final result = await checkPackage(root: '${d.sandbox}/web_pkg'); |
| 153 | + expect(result, isTrue); |
| 154 | + }); |
| 155 | + |
| 156 | + test('works with workspace subpackages that contain nested packages', |
| 157 | + () async { |
| 158 | + final workspacePubspec = Pubspec( |
| 159 | + 'workspace_root', |
| 160 | + environment: requireDart36, |
| 161 | + workspace: ['pkgs/code_assets'], |
| 162 | + ); |
| 163 | + |
| 164 | + final subpackagePubspec = Pubspec( |
| 165 | + 'code_assets', |
| 166 | + environment: requireDart36, |
| 167 | + resolution: 'workspace', |
| 168 | + dependencies: { |
| 169 | + 'http': HostedDependency(version: VersionConstraint.any), |
| 170 | + }, |
| 171 | + ); |
| 172 | + |
| 173 | + final nestedPubspec = Pubspec( |
| 174 | + 'host_name', |
| 175 | + environment: requireDart36, |
| 176 | + dependencies: { |
| 177 | + 'ffigen': HostedDependency(version: VersionConstraint.any), |
| 178 | + }, |
| 179 | + ); |
| 180 | + |
| 181 | + final dir = d.dir('workspace', [ |
| 182 | + d.file('pubspec.yaml', jsonEncode(workspacePubspec.toJson())), |
| 183 | + d.dir('pkgs', [ |
| 184 | + d.dir('code_assets', [ |
| 185 | + d.file('pubspec.yaml', jsonEncode(subpackagePubspec.toJson())), |
| 186 | + d.dir('lib', [ |
| 187 | + d.file('code_assets.dart', 'import "package:http/http.dart";'), |
| 188 | + ]), |
| 189 | + d.dir('example', [ |
| 190 | + d.dir('host_name', [ |
| 191 | + d.file('pubspec.yaml', jsonEncode(nestedPubspec.toJson())), |
| 192 | + d.dir('tool', [ |
| 193 | + d.file( |
| 194 | + 'ffigen.dart', 'import "package:ffigen/ffigen.dart";'), |
| 195 | + ]), |
| 196 | + ]), |
| 197 | + ]), |
| 198 | + ]), |
| 199 | + ]), |
| 200 | + ]); |
| 201 | + |
| 202 | + await dir.create(); |
| 203 | + final result = await checkPackage(root: '${d.sandbox}/workspace'); |
| 204 | + expect(result, isTrue); |
| 205 | + }); |
| 206 | + }); |
0 commit comments