Show a more accurate star rating. #670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This does change the rounding of values so that a 3.8 used to render as 4 stars, but now renders as 3½, which also means that only plugins with a 5 will get the 5 stars. Twenty Twenty-Four with a 3.8 rating:
The card view also currently uses a rounded view (it still uses
|
Contributor
|
The change in 43bb8a5 brings back the previous rounding code for the stars themselves, but calculates a separate unrounded display rating: 
|
Contributor
Author
|
Makes sense. Thanks for the help kelly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes rounding for display averages as discussed in WordPress/wporg-theme-directory#147 (comment) and WordPress/wordpress.org#408 (comment). This is particularly important for plugins as most plugins fall within the 4-5 star ranges and rounding makes it difficult to compare plugins by ratings.
Themes
Plugins