Merged
Conversation
…previous versions of PHP.
7 tasks
Member
Author
|
PHP 8.0.0rc1 is out and the corresponding docker image. Mobile at the moment, but wanted to note that the PR should be updated to use RC1. |
jrfnl
reviewed
Oct 2, 2020
wpscholar
approved these changes
Oct 6, 2020
Member
wpscholar
left a comment
wpscholar
left a comment
There was a problem hiding this comment.
Looks good. Validated that missing extensions were installed. Looked up Memcached version compatibility with PHP 8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to bring the PHP8 Docker setup to match the ones for previous versions of PHP.
Changes:
base_namefor PHP 8 was switched tophp:8.0:beta4-fpm. Previouslydevilboxwas used, but the PHP 8 image was using PHP 8.0.0-dev. Changing this to be more specific will require an update as newer 8.0 beta/RC releases are published, but it will be more accurate than8.0.0-dev.pecl install. This PR installs Pickle, which is new PHP extension installer aiming to get Composer to fully support it.Still missing, but not blockers (will require follow-up PRs when the libraries are updated):