refactor: initially render bell icon server side #310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnhooks
force-pushed
the
refactor/bell-icon
branch
2 times, most recently
from
c674bac to
3b47950
Compare
johnhooks
force-pushed
the
refactor/bell-icon
branch
from
3b47950 to
289896f
Compare
johnhooks
commented
Apr 26, 2023
Comment on lines
66
to
83
| <div className="ab-item ab-empty-item" tabIndex={ 0 }> | ||
| <ShortcutProvider | ||
| className={ classNames( [ | ||
| 'notifications', | ||
| isActive ? 'active' : '', | ||
| ] ) } | ||
| > | ||
| <NotificationHubIcon | ||
| toggle={ toggleDrawer } | ||
| isActive={ isActive } | ||
| /> | ||
| <Drawer | ||
| instance={ drawerRef } | ||
| focus={ () => setIsActive( true ) } | ||
| blur={ () => setIsActive( false ) } | ||
| /> | ||
| </ShortcutProvider> | ||
| </div> |
Collaborator
Author
There was a problem hiding this comment.
Wrapping this in div.ab-item.ab-empty-item creates the same HTML structure as WordPress creates for the menu item.
johnhooks
commented
Apr 26, 2023
|
|
||
| /* the bell icon */ | ||
| .ab-item { | ||
| .hub-icon { |
Collaborator
Author
There was a problem hiding this comment.
Changing this name to reflect it's purpose, and the case ab-item has been moved up higher in the DOM structure.
johnhooks
commented
Apr 26, 2023
| appearance: none; | ||
| height: 32px; | ||
| display: block; | ||
| padding: 0 10px; |
Collaborator
Author
There was a problem hiding this comment.
The ab-empty-item class provides the padding. The ab-empty-item class is applied to menu items that do not have a link.
johnhooks
force-pushed
the
refactor/bell-icon
branch
from
0291fab to
5b9f64e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Render the bell icon on the server.
Why?
The bell icon would appear after the JavaScript loaded and cause the icon to jump on every page transition.
How?
@erikyo helped me with the code required to render the bell in the admin bar.
TODO