Skip to content

feature(mvp): add initial channel and subscription rest controllers #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
johnhooks merged 2 commits into from
Apr 22, 2023
Merged

feature(mvp): add initial channel and subscription rest controllers #300

johnhooks merged 2 commits into from
Apr 22, 2023

Conversation

@johnhooks
Copy link
Collaborator

@johnhooks johnhooks commented Apr 22, 2023

What?

Add an initial channel rest controller.

Why?

To allow fetching a list of all available notification channels in the client.

Additionally

  • Reorganized the initialization of the rest controllers.
  • Added tests for the Channel_Controller schema.
  • Added a missing icon schema property to the Notification_Controller

@johnhooks johnhooks force-pushed the feature/add-channel-controller branch from 271a0d0 to b4fb600 Compare April 22, 2023 14:03
@johnhooks johnhooks added the [Scope] Service The core logic of the WP Notify project. label Apr 22, 2023
@johnhooks johnhooks changed the title feature: add initial channel rest controller feature(mvp): add initial channel rest controller Apr 22, 2023
@johnhooks johnhooks requested a review from erikyo April 22, 2023 17:23
@johnhooks johnhooks changed the title feature(mvp): add initial channel rest controller feature(mvp): add initial channel and subscription rest controllers Apr 22, 2023
erikyo
erikyo approved these changes Apr 22, 2023
View reviewed changes
Copy link
Collaborator

@erikyo erikyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@johnhooks johnhooks merged commit 94b2262 into WordPress:develop Apr 22, 2023
@johnhooks johnhooks deleted the feature/add-channel-controller branch April 22, 2023 17:29
@johnhooks johnhooks mentioned this pull request Apr 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erikyo erikyo erikyo approved these changes

Assignees

No one assigned

Labels

[Scope] Service The core logic of the WP Notify project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@johnhooks @erikyo