feature(mvp): Stage 4 - add activator and uninstaller #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnhooks
changed the title
johnhooks
force-pushed
the
feature/add-activate
branch
from
6c0f764 to
77e4429
Compare
johnhooks
changed the title
johnhooks
added
the
[Scope] Database / Persistence
fix: uninstall drop table names fix: format error chore: remove logging fix: add uninstall hook fix: use of deactivate in uninstall fix: remove logging function feature: add support for multisite fix: Use Yoda Condition checks, you must fix: add/remove options in each multisite instance chore: fix comment formating fix: nullable notification message meta test: add activate and uninstall tests refactor: add type hint to db-test-case fix: package name PHPDoc comments
johnhooks
force-pushed
the
feature/add-activate
branch
from
77e4429 to
fd58000
Compare
johnhooks
force-pushed
the
feature/add-activate
branch
from
fd58000 to
a824fa9
Compare
johnhooks
force-pushed
the
feature/add-activate
branch
from
ee02d19 to
d45ceb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds plugin activator and uninstaller. The database SQL to create the database tables for the plugin are in the
Database\Schemastatic class.Why?
Need to be able to install the plugin and have a database to contain the notification data.
Reopening of #199