Skip to content

feature(mvp): Stage 3 - add channel registry #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
johnhooks merged 2 commits into from
Apr 21, 2023
Merged

feature(mvp): Stage 3 - add channel registry #291

johnhooks merged 2 commits into from
Apr 21, 2023

Conversation

@johnhooks
Copy link
Collaborator

@johnhooks johnhooks commented Apr 20, 2023

What?

Add functions and a registry for managing channels.

  • Channel_Registry class
  • register_channel function
  • unregister_channel function

Why?

The Channel objects will be held entirely in code. The registry is highly influenced by the WP_Block_Type_Registry.

@johnhooks johnhooks force-pushed the feature/add-channel-registry branch 2 times, most recently from dcc8da7 to 15d4097 Compare April 20, 2023 22:33
@johnhooks johnhooks added [Status] Blocked When another issue need to be taken care of first. [Scope] Service The core logic of the WP Notify project. labels Apr 21, 2023
@johnhooks johnhooks self-assigned this Apr 21, 2023
@johnhooks johnhooks force-pushed the feature/add-channel-registry branch from 15d4097 to 4fca9c9 Compare April 21, 2023 17:58
@johnhooks johnhooks force-pushed the feature/add-channel-registry branch from 4fca9c9 to 56ce6f8 Compare April 21, 2023 18:00
@johnhooks johnhooks removed the [Status] Blocked When another issue need to be taken care of first. label Apr 21, 2023
@johnhooks johnhooks requested review from Sephsekla and erikyo April 21, 2023 18:03
@johnhooks johnhooks force-pushed the feature/add-channel-registry branch from ba2fa2c to feba49e Compare April 21, 2023 18:15
@johnhooks johnhooks force-pushed the feature/add-channel-registry branch from feba49e to f9a015c Compare April 21, 2023 18:18
erikyo
erikyo approved these changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@erikyo erikyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@johnhooks johnhooks merged commit caec9bf into WordPress:develop Apr 21, 2023
@johnhooks johnhooks deleted the feature/add-channel-registry branch April 21, 2023 18:27
@johnhooks johnhooks mentioned this pull request Apr 21, 2023
Closed
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erikyo erikyo erikyo approved these changes

@Sephsekla Sephsekla Awaiting requested review from Sephsekla

Assignees

@johnhooks johnhooks

Labels

[Scope] Service The core logic of the WP Notify project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@johnhooks @erikyo