Skip to content

feature(mvp): Stage 3 - add initial factory classes #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
johnhooks merged 2 commits into from
Apr 21, 2023
Merged

feature(mvp): Stage 3 - add initial factory classes #290

johnhooks merged 2 commits into from
Apr 21, 2023

Conversation

@johnhooks
Copy link
Collaborator

@johnhooks johnhooks commented Apr 20, 2023 •
edited
Loading

What?

Add the initial factory classes.

  • Factory\Message
  • Factory\Notification
  • Factory\Subscription
  • Framework\Factory

Why?

Builds on the models of #289. Abstracts the creation of model objects using an array argument through the factory.

Blocked until #289 is merged.

Additionally

  • Modified the base TestCase to be based on PHPUnit_Adapter_TestCase.

@johnhooks johnhooks added [Status] Blocked When another issue need to be taken care of first. [Scope] Model Definition of the data used in the WP Notify project labels Apr 20, 2023
@johnhooks johnhooks force-pushed the feature/add-initial-factories branch 2 times, most recently from 1ca03a2 to 50788cf Compare April 20, 2023 15:32
@johnhooks johnhooks self-assigned this Apr 21, 2023
@johnhooks johnhooks force-pushed the feature/add-initial-factories branch 2 times, most recently from f71fb5b to 7e09dc4 Compare April 21, 2023 04:40
@johnhooks johnhooks removed the [Status] Blocked When another issue need to be taken care of first. label Apr 21, 2023
@johnhooks johnhooks force-pushed the feature/add-initial-factories branch from 7e09dc4 to 2db9dd6 Compare April 21, 2023 19:12
@johnhooks johnhooks force-pushed the feature/add-initial-factories branch from 2db9dd6 to ec961e3 Compare April 21, 2023 19:25
erikyo
erikyo approved these changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@erikyo erikyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@johnhooks johnhooks merged commit e418273 into WordPress:develop Apr 21, 2023
@johnhooks johnhooks deleted the feature/add-initial-factories branch April 21, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erikyo erikyo erikyo approved these changes

Assignees

@johnhooks johnhooks

Labels

[Scope] Model Definition of the data used in the WP Notify project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@johnhooks @erikyo