Skip to content

fix: rest api namespace #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
johnhooks merged 1 commit into from
Apr 19, 2023
Merged

fix: rest api namespace #283

johnhooks merged 1 commit into from
Apr 19, 2023

Conversation

@johnhooks
Copy link
Collaborator

@johnhooks johnhooks commented Apr 19, 2023

What?

Move the REST API namespace off the one reserved for WordPress.

Why?

Until this is merged into core, it should use it's own namespace.

Fixes #194

@johnhooks johnhooks added the [Scope] Service The core logic of the WP Notify project. label Apr 19, 2023
erikyo
erikyo approved these changes Apr 19, 2023
View reviewed changes
Copy link
Collaborator

@erikyo erikyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@johnhooks johnhooks merged commit c070577 into WordPress:develop Apr 19, 2023
@johnhooks johnhooks deleted the fix/rest-namespace branch April 19, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erikyo erikyo erikyo approved these changes

Assignees

No one assigned

Labels

[Scope] Service The core logic of the WP Notify project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Change rest-api namespace to wp-notifications/v1

2 participants

@johnhooks @erikyo