-
Notifications
You must be signed in to change notification settings - Fork 17
feature: mvp #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: mvp #259
Conversation
745860b to
cbe0996
Compare
|
This is looking phenomenal already, thanks for the hard work here! |
|
@Sephsekla thanks, it feels like its coming a long well. Right now I'm going for simple, a lot will need adjusting to make the rest api function the way I would expect. Right now I don't have the right features in the models/factories/repositories for supporting |
|
@johnhooks when you have a sec, do you mind having a look at these merge conflicts? I'd like to try and get this rolling again by splitting out some of the remaining work (and possibly merging this one to development as is), but I'm not sure how to reslve things. |
|
@Sephsekla this branch should actually be closed, all of the features of this branch have already been merged in. I brought all of this into |
What?
Create a minimum viable product of the notification plugin.
Why?
There is still a lot to learn, but we need a minimally functional system to explore the possiblities.
How?
Combines PRs:
Necessary functionality for MVP*
Notification_Controllerwp-notifications/v1/notificationsGET /notifications/GET /notifications/{id}POST /notifications/{id}PUT /notifications /{id}DELETE /notifications /{id}Subscription_Controllerwp-notifications/v1/subscriptionsGET /subscriptions/GET /subscriptions/{id}POST /subscriptions/{id}PUT /subscriptions /{id}DELETE /subscriptions /{id}