Add the pattern preview #169
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akirk
reviewed
Jul 31, 2023
...s.org/public_html/wp-content/plugins/wporg-gp-virtual-projects/wporg-gp-virtual-projects.php
Outdated
Show resolved
Hide resolved
…projects/wporg-gp-virtual-projects.php Co-authored-by: Alex Kirk <[email protected]>
Member
|
After some hiccups with getting the patch applied and realizing I need to append |
Contributor
Author
|
@akirk can you review this related GlotPress PR, so we can include it in the next GlotPress release? |
akirk
approved these changes
Sep 20, 2023
Member
akirk
left a comment
akirk
left a comment
There was a problem hiding this comment.
GlotPress/GlotPress#1665 is already approved, we can move ahead with this one!
bazza
pushed a commit
that referenced
this pull request
Sep 20, 2023
See #169 git-svn-id: https://meta.svn.wordpress.org/sites/trunk@12904 74240141-8908-4e6f-9713-ba540dce6ec7
Contributor
Author
|
I have released this PR to production and I have informed to the community about this improvement. I close this PR. |
outdoor2kode
pushed a commit
to outdoor2kode/wordpress.org
that referenced
this pull request
Jan 28, 2024
See WordPress#169 git-svn-id: https://meta.svn.wordpress.org/sites/trunk@12904 74240141-8908-4e6f-9713-ba540dce6ec7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When you see the strings to translate in a pattern, you don't have a live preview to be able to see the strings in context.
Solution
This PR adds the live preview for the patterns, using the filter and action added in GlotPress.
Responsive preview (under 1280 px)
Testing Instructions
You need to use this GlotPress branch (or the develop branch if this branch has been merged).
You need to add the
&pattern_preview=truetext in the URL to enable this preview.To test this PR: