Rrefactor defineWpConfigConsts to work on virtual file system
#415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
reviewed
May 23, 2023
packages/playground/blueprints/src/lib/steps/define-wp-config-consts.ts
Outdated
Show resolved
Hide resolved
Collaborator
|
Thank you @sejas! Something is wrong with the formatting, though. I added a husky pre-commit hook to run |
…to update/refactpr-define-wp-config-consts-step
Collaborator
Author
Collaborator
Author
|
@adamziel, can I merge this branch? |
Collaborator
Author
|
@adamziel, I would appreciate a final review of this PR. Thank you! |
adamziel
reviewed
May 26, 2023
Collaborator
adamziel
left a comment
adamziel
left a comment
There was a problem hiding this comment.
Almost there, I only left a few nit picks. Thank you for working on this!
packages/playground/blueprints/src/lib/steps/define-wp-config-consts.ts
Outdated
Show resolved
Hide resolved
packages/playground/blueprints/src/lib/steps/define-wp-config-consts.ts
Outdated
Show resolved
Hide resolved
Collaborator
|
Thank you for consolidating that logic @sejas! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Remove
defineVirtualWpConfigConstsin favor ofdefineWpConfigConsts, adding avirtualizeoption.Why?
Code optimization discussed here #343 (comment)
Testing Instructions
nx preview wp-now start --path=/path/to/wordpress-plugin-or-themeplayground-consts.jsonfile added to the root of wordpress.