Skip to content

Fix: Update returned value from wp-now for index mode #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix: Update returned value from wp-now for index mode #325

wants to merge 1 commit into from

Conversation

kozer
Copy link
Contributor

@kozer kozer commented May 12, 2023 •
edited
Loading

Fixes starting issue for index mode, as the current implementation throws an error.

Testing instructions

  • Start wp-now and point it to a folder that has only an index.php file.
  • Ensure that it doesn't throw an error

@kozer kozer self-assigned this May 12, 2023
@kozer kozer changed the title Fix: Update returned value from wp-now Fix: Update returned value from wp-now for index mode May 12, 2023
@kozer kozer added [Type] Bug An existing feature does not function as intended Local Environment i1 labels May 12, 2023
@kozer kozer requested a review from sejas May 12, 2023 13:40
@danielbachhuber
Copy link
Member

Thanks @kozer ! As it turns out, we just fixed this with #321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sejas sejas

Assignees

@kozer kozer

Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kozer @danielbachhuber