[CLI] Fix incorrect Xdebug mappings for absolute host paths#2860
Merged
brandonpayton merged 3 commits intotrunkfrom Nov 4, 2025
Merged
[CLI] Fix incorrect Xdebug mappings for absolute host paths#2860brandonpayton merged 3 commits intotrunkfrom
brandonpayton merged 3 commits intotrunkfrom
Conversation
brandonpayton
added
[Type] Bug
Member
Author
|
Looks like this change broke in Windows. I'm so thankful for those tests. OK, will examine and fix. |
Member
Author
|
This looks good to go. It's blocking some basic uses of the Xdebug IDE integration as I am trying to make a short video of using the feature, so I'm going to merge now and release new packages. |
brandonpayton
deleted the
xdebug-ide-integration/make-child-paths-relative
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
When auto-mounting a plugin dir and using Xdebug IDE integration, I am seeing the following incorrect path mappings for a local project dir of
/Users/brandon/src/test-plugin:"/wordpress/wp-content/plugins/test-plugin": "${workspaceFolder}//Users/brandon/src/test-plugin"<mapping local-root="$PROJECT_DIR$//Users/brandon/src/test-plugin" remote-root="/wordpress/wp-content/plugins/test-plugin"></mapping>Implementation details
This PR fixes such paths so they are mapped like:
"/wordpress/wp-content/plugins/test-plugin": "${workspaceFolder}/"<mapping local-root="$PROJECT_DIR$/" remote-root="/wordpress/wp-content/plugins/test-plugin"></mapping>I also added two new tests cases for this.
Testing Instructions (or ideally a Blueprint)