[PHP] Improve error logging #2357
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
Cleans up the data flows for logging errors. Before this PR, some things would be always logged, other errors would be emitted as events, and others thrown. With this PR, errors are thrown and propagated to the caller – even across the Comlink boundary. This PR introduces an enhanced error serializer/unserializer that preserves the
causeand custom properties (e.g.error.status).Improved the logging surfaced a few tactical problems, so this PR also changes a few nuances here and there, e.g. how
PHPProcessManager.spawn()ensures the primary instance isn't acquired twice, or thatcreateNodeFsMountHandlerreturns a synchronous, not async function.Related to #2298
Testing Instructions (or ideally a Blueprint)
Confirm all the unit tests still pass