[Website] Fix "undefined" as className #1870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Thank you for the small stuff! :)
Feel free to reach out on #meta-playground slack channel and start issues and discussions about things that aren't clear – it would all be helpful feedback on how can we improve the clarity :) |
adamziel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
I found "undefined" as a class name in the rendered DOM code.
Implementation details
Remove potentially empty prop from string chain to classNames() method.
Testing Instructions (or ideally a Blueprint)
Just open playground. It's on the main page as a wrapper.
Ps. Sorry for the small stuff. I'm trying to find my way around the code :)