Skip to content

Move DefineSiteUrlStep doc warning so it displays in docs#1245

Merged
adamziel merged 1 commit intoWordPress:trunkfrom
artpi:siteurlstep_docs
Apr 15, 2024
Merged

Move DefineSiteUrlStep doc warning so it displays in docs#1245
adamziel merged 1 commit intoWordPress:trunkfrom
artpi:siteurlstep_docs

Conversation

@artpi
Copy link
Collaborator

@artpi artpi commented Apr 15, 2024

What is this PR doing?

In 05df9ee @adamziel has made a comment about DefineSiteUrlStep step. This comment is not showing in docs.

I moved that comment to a place where this doc is displayed

What problem is it solving?

@adamziel comment is currently not displaying properly in the docs

Zrzut ekranu 2024-04-15 o 15 29 41

How is the problem addressed?

Move the comment to a place where the docs are sourced

Testing Instructions

  • npm run build:docs
  • Open dist/docs/build/blueprints-api/steps/index.html
  • Confirm the comment is there under the DefineSiteUrlStep step

@artpi artpi requested a review from adamziel April 15, 2024 13:33
@adamziel adamziel merged commit ce4cfa8 into WordPress:trunk Apr 15, 2024
@adamziel
Copy link
Collaborator

Ah 🤦 Lovely, thank you @artpi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants