Fix PHP 8.3 compatibility warnings in regex parser #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add isset() check before accessing array key in author processing (line 65) - Add null check before preg_match() to prevent deprecated warning (line 118) - Add similar safety checks for other array access patterns - Maintains backward compatibility while eliminating PHP 8.3 warnings Fixes WordPress#176
|
If i am not mistaken: Support for the Regex Parser is abandoned as fas as i understood. The new version does not call it anymore. It is only there for backwards compatibility for programmers who are still calling it. |
Contributor
|
@BackuPs you're right! This PR could still be valuable in those cases and it seems to be reasonably safe so I'll go ahead and merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #176