Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
dmsnell
left a comment
dmsnell
left a comment
There was a problem hiding this comment.
@SirLouen I took the liberty of making a small update to this PR. When I read the data provider I was a bit confused on what it was trying to show, so I renamed the keys to align with the functional use of the embed parameter. I also removed the extra wrapping of the 'embed' => array() in each test case because I thought that might have gone beyond what @aaronjorbin was asking about when mentioning associative arrays.
Happy to remove this commit if you disagree; otherwise I or anyone can merge it before the beta cut. Regardless, as a tests update we can still get it in during the beta without issue.
|
@dmsnell The wrapping is so that it passes it as an array and not as three strings. The renaming looks good though |
|
thanks @aaronjorbin — I see that now. I guess I removed the inner array too, which should have stayed. thanks for following-up on it! |
3 participants
This PR improves the unit tests providing the 3 potential scenarios with arrays, mixed, associative and index arrays as suggested by @jorbin
Trac ticket: https://core.trac.wordpress.org/ticket/28059
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.