Skip to content

Conversation

@sirreal
Copy link
Member

@sirreal sirreal commented Aug 28, 2025

</br> gets special treatment in the HTML standard. It creates a BR element with no attributes (regardless of whether it appears to have attributes in the HTML like </br attr-name>).

  • Stop on </br> in ::next_tag() like other openers.
  • Return array() from ::get_attribute_names_with_prefix() on </br> instead of null like true close tags.
  • Add tests.

Trac ticket: https://core.trac.wordpress.org/ticket/63891


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

github-actions bot commented Aug 28, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props jonsurrell, dmsnell.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@sirreal sirreal requested a review from dmsnell August 28, 2025 14:19
@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@github-actions
Copy link

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 61197
GitHub commit: 03171e1

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions bot closed this Nov 10, 2025
@dmsnell
Copy link
Member

dmsnell commented Nov 12, 2025

@desrosj looks like this is another victim of over-eager bots closing work that wasn’t merged. this patch was related to the Core ticket mentioned in the SVN commit, but the actual changeset was orthogonal to it.

@dmsnell dmsnell reopened this Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants