Skip to content

Conversation

@rollybueno
Copy link

Adds comprehensive unit test to verify RSS feed cache transient storage behavior for ticket #63719.

Trac ticket: https://core.trac.wordpress.org/ticket/63167


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

github-actions bot commented Jul 31, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props rollybueno, peterwilsoncc.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@rollybueno
Copy link
Author

As per feedback in ticket #63719

@peterwilsoncc
Copy link
Contributor

@rollybueno The tests can be independent of fetch_feed() as there are already tests validating that the data is cached.

For site transients tests, can use simpler tests to gaurentee that the data is stored in the correct table depending on how WordPress is configured. I didn't get to finish them, but I started some experiments yesterday if you want to pick up the code as a startying point.

#9352

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@rollybueno
Copy link
Author

Hey @peterwilsoncc - I checked your PR on #9352. I think it's covering more specific requirements for the site transient storage location and way more cleaner solution than what I have here. I'll close this PR and we can go with your implementation. Appreciate the feedback 👍.

@rollybueno rollybueno closed this Aug 1, 2025
@peterwilsoncc
Copy link
Contributor

@rollybueno Thanks, are you able to post any notes on the other PR so we can a) ensure you get props for the suggestion and b) I can get a logic check on any further use cases that might need to be tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants