Skip to content

Restore caching to fetch_feed().#9280

Closed
peterwilsoncc wants to merge 11 commits intoWordPress:trunkfrom
peterwilsoncc:fix/63717-fetch-feed-caching
Closed

Restore caching to fetch_feed().#9280
peterwilsoncc wants to merge 11 commits intoWordPress:trunkfrom
peterwilsoncc:fix/63717-fetch-feed-caching

Conversation

@peterwilsoncc
Copy link
Contributor

@peterwilsoncc peterwilsoncc commented Jul 17, 2025

Restore caching to the fetch_feed() function.

As noted on the ticket, I'd like to update to 1.8.1 with the caching fix included but I've asked for an assist first. See WP63717 (comment)

Trac ticket: https://core.trac.wordpress.org/ticket/63717


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@peterwilsoncc peterwilsoncc force-pushed the fix/63717-fetch-feed-caching branch from b00f33b to 0dffb02 Compare July 18, 2025 00:01
@peterwilsoncc peterwilsoncc marked this pull request as ready for review July 18, 2025 02:21
@github-actions
Copy link

github-actions bot commented Jul 18, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props peterwilsoncc, sergeybiryukov.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@SergeyBiryukov SergeyBiryukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one suggestion, looks good otherwise 👍

Co-authored-by: Sergey Biryukov <[email protected]>
@peterwilsoncc peterwilsoncc requested a review from dd32 July 18, 2025 02:34
@peterwilsoncc peterwilsoncc force-pushed the fix/63717-fetch-feed-caching branch from ab7ad59 to 1623ed2 Compare July 18, 2025 02:49
@github-actions
Copy link

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 60490
GitHub commit: f0a3c68

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions bot closed this Jul 21, 2025
@peterwilsoncc peterwilsoncc deleted the fix/63717-fetch-feed-caching branch July 21, 2025 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants