Skip to content

HTML API: Use assertEqualHTML() in media tests. #9264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dmsnell wants to merge 1 commit into from
Closed

HTML API: Use assertEqualHTML() in media tests. #9264

dmsnell wants to merge 1 commit into from

Conversation

@dmsnell
Copy link
Member

@dmsnell dmsnell commented Jul 15, 2025 •
edited
Loading

Trac ticket: Core-63694

Prep work for #9248.

dmsnell added a commit to dmsnell/wordpress-develop that referenced this pull request Jul 15, 2025
@dmsnell
HTML API: Use assertEqualHTML() in media tests. (WordPress#9264)
0db6cb5 
Prep work for WordPress#9248.
@dmsnell dmsnell force-pushed the html-api/tests-media branch from aa0cfea to 0db6cb5 Compare July 15, 2025 02:54
@dmsnell dmsnell mentioned this pull request Jul 15, 2025
Open
@github-actions
Copy link

github-actions bot commented Jul 15, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@dmsnell dmsnell marked this pull request as ready for review July 15, 2025 16:03
@github-actions
Copy link

github-actions bot commented Jul 15, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props dmsnell, jonsurrell.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

dmsnell added a commit to dmsnell/wordpress-develop that referenced this pull request Jul 15, 2025
@dmsnell
HTML API: Use assertEqualHTML() in media tests. (WordPress#9264)
bbc07a3 
Prep work for WordPress#9248.
@dmsnell dmsnell force-pushed the html-api/tests-media branch from 0db6cb5 to bbc07a3 Compare July 15, 2025 16:12
sirreal
sirreal approved these changes Jul 16, 2025
View reviewed changes
Copy link
Member

@sirreal sirreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice improvement for the clarity of test output. The additional checks in this test are nice additions as well.

dmsnell added a commit to dmsnell/wordpress-develop that referenced this pull request Jul 18, 2025
@dmsnell
HTML API: Use assertEqualHTML() in media tests. (WordPress#9264)
59d7197 
Prep work for WordPress#9248.
@dmsnell dmsnell force-pushed the html-api/tests-media branch from bbc07a3 to 59d7197 Compare July 18, 2025 19:38
dmsnell added a commit to dmsnell/wordpress-develop that referenced this pull request Jul 18, 2025
@dmsnell
HTML API: Use assertEqualHTML() in media tests. (WordPress#9264)
b077057 
Prep work for WordPress#9248.
@dmsnell dmsnell force-pushed the html-api/tests-media branch from 59d7197 to b077057 Compare July 18, 2025 21:03
@github-actions
Copy link

github-actions bot commented Aug 26, 2025

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 60665
GitHub commit: 2abe245

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions bot closed this Aug 26, 2025
@dmsnell dmsnell reopened this Aug 26, 2025
@github-actions
Copy link

github-actions bot commented Sep 10, 2025

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 60726
GitHub commit: 00b3b63

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions bot closed this Sep 10, 2025
@dmsnell
Copy link
Member Author

dmsnell commented Sep 10, 2025

If I had a dime, @github-actions, for every time you barged in and interrupted my work, I wouldn’t need to work.

Oh if only you gave some indication of where to go to restrain your over-zealous ideology, forcing your mindset arbitrarily on those around you, oh what a bug report or patch I would love to provide. But no, you are faceless, left only to deny and reject and delete. You are @github-actions-I-will-destroy bot, born to raze and raised to burn.

@dmsnell dmsnell reopened this Sep 10, 2025
@dmsnell dmsnell force-pushed the html-api/tests-media branch from b077057 to b709f55 Compare October 18, 2025 23:52
pento pushed a commit that referenced this pull request Oct 19, 2025
@dmsnell
HTML API: Rely on assertEqualHTML in media tests.
86546fd 
As part of ongoing work to improve the reliability of HTML parsing code in WordPress, this patch replaces strict string-equality tests with semantic tests using `assertEqualHTML()` to more direct assert intended behaviors.

Developed in #9264
Discussed in https://core.trac.wordpress.org/ticket/63694

Props dmsnell, jonsurrell.
See #63694


git-svn-id: https://develop.svn.wordpress.org/trunk@60971 602fd350-edb4-49c9-b593-d223f7449a82
@dmsnell
Copy link
Member Author

dmsnell commented Oct 19, 2025

Merged in 86546fd
[60971]

@dmsnell dmsnell closed this Oct 19, 2025
@dmsnell dmsnell deleted the html-api/tests-media branch October 19, 2025 00:12
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Oct 19, 2025
@dmsnell
HTML API: Rely on assertEqualHTML in media tests.
ce6911f 
As part of ongoing work to improve the reliability of HTML parsing code in WordPress, this patch replaces strict string-equality tests with semantic tests using `assertEqualHTML()` to more direct assert intended behaviors.

Developed in WordPress/wordpress-develop#9264
Discussed in https://core.trac.wordpress.org/ticket/63694

Props dmsnell, jonsurrell.
See #63694

Built from https://develop.svn.wordpress.org/trunk@60971


git-svn-id: http://core.svn.wordpress.org/trunk@60307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot pushed a commit to platformsh/wordpress-performance that referenced this pull request Oct 19, 2025
@dmsnell
HTML API: Rely on assertEqualHTML in media tests.
e3ce54c 
As part of ongoing work to improve the reliability of HTML parsing code in WordPress, this patch replaces strict string-equality tests with semantic tests using `assertEqualHTML()` to more direct assert intended behaviors.

Developed in WordPress/wordpress-develop#9264
Discussed in https://core.trac.wordpress.org/ticket/63694

Props dmsnell, jonsurrell.
See #63694

Built from https://develop.svn.wordpress.org/trunk@60971


git-svn-id: https://core.svn.wordpress.org/trunk@60307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sirreal sirreal sirreal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dmsnell @sirreal