-
Notifications
You must be signed in to change notification settings - Fork 3.2k
HTML API: Use assertEqualHTML() in wp_rel_nofollow() tests.
#9251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Prep work for WordPress#9248 See also WordPress#9251
Prep work for WordPress#9248 See also WordPress#9251
Prep work for WordPress#9248 See also WordPress#9251
23c6cfe to
968ca3f
Compare
Prep work for WordPress#9248 See also WordPress#9251
968ca3f to
f59a3c0
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
sirreal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good.
f59a3c0 to
d867180
Compare
Trac Ticket MissingThis pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook. |
As part of ongoing work to improve the reliability of HTML parsing code in WordPress, this patch replaces strict string-equality checks with semantic checks via `assertEqualHTML()` for more-direct assertions. Developed in #9251 Discussed in https://core.trac.wordpress.org/ticket/63694 Props dmsnell, jonsurrell. See #63694 git-svn-id: https://develop.svn.wordpress.org/trunk@60974 602fd350-edb4-49c9-b593-d223f7449a82
As part of ongoing work to improve the reliability of HTML parsing code in WordPress, this patch replaces strict string-equality checks with semantic checks via `assertEqualHTML()` for more-direct assertions. Developed in WordPress/wordpress-develop#9251 Discussed in https://core.trac.wordpress.org/ticket/63694 Props dmsnell, jonsurrell. See #63694 Built from https://develop.svn.wordpress.org/trunk@60974 git-svn-id: http://core.svn.wordpress.org/trunk@60310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
As part of ongoing work to improve the reliability of HTML parsing code in WordPress, this patch replaces strict string-equality checks with semantic checks via `assertEqualHTML()` for more-direct assertions. Developed in WordPress/wordpress-develop#9251 Discussed in https://core.trac.wordpress.org/ticket/63694 Props dmsnell, jonsurrell. See #63694 Built from https://develop.svn.wordpress.org/trunk@60974 git-svn-id: https://core.svn.wordpress.org/trunk@60310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Prep work for #9248