HTML API: Simplify META tag encoding processing #9231
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
sirreal
force-pushed
the
html-api/simplify-meta-tag-encoding-handling
branch
from
86e40c4 to
77aadec
Compare
12 tasks
dmsnell
reviewed
Jul 22, 2025
dmsnell
reviewed
Jul 23, 2025
Member
dmsnell
left a comment
dmsnell
left a comment
There was a problem hiding this comment.
I left some notes to make the versions all concrete. after that I think this is ready to go.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
dmsnell
approved these changes
Jul 23, 2025
Member
dmsnell
left a comment
dmsnell
left a comment
There was a problem hiding this comment.
This looks ready. At some point we can benchmark it.
sirreal
force-pushed
the
html-api/simplify-meta-tag-encoding-handling
branch
from
9a01561 to
81e0713
Compare
This prevents a test case from running
pento
pushed a commit
that referenced
this pull request
Jul 24, 2025
META tag processing can be simplified in most cases. Add an early check and return to avoid additional processing. Developed in #9231. Props jonsurrell, dmsnell. See #63738. git-svn-id: https://develop.svn.wordpress.org/trunk@60502 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Jul 24, 2025
META tag processing can be simplified in most cases. Add an early check and return to avoid additional processing. Developed in WordPress/wordpress-develop#9231. Props jonsurrell, dmsnell. See #63738. Built from https://develop.svn.wordpress.org/trunk@60502 git-svn-id: http://core.svn.wordpress.org/trunk@59838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Member
Author
|
Merged in [60502]. |
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Jul 24, 2025
META tag processing can be simplified in most cases. Add an early check and return to avoid additional processing. Developed in WordPress/wordpress-develop#9231. Props jonsurrell, dmsnell. See #63738. Built from https://develop.svn.wordpress.org/trunk@60502 git-svn-id: https://core.svn.wordpress.org/trunk@59838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Ninos
pushed a commit
to Ninos/wordpress-develop
that referenced
this pull request
Jul 28, 2025
META tag processing can be simplified in most cases. Add an early check and return to avoid additional processing. Developed in WordPress#9231. Props jonsurrell, dmsnell. See #63738. git-svn-id: https://develop.svn.wordpress.org/trunk@60502 602fd350-edb4-49c9-b593-d223f7449a82
jonnynews
pushed a commit
to spacedmonkey/wordpress-develop
that referenced
this pull request
Sep 24, 2025
META tag processing can be simplified in most cases. Add an early check and return to avoid additional processing. Developed in WordPress#9231. Props jonsurrell, dmsnell. See #63738. git-svn-id: https://develop.svn.wordpress.org/trunk@60502 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: Core-63738
Simplify META tag handling with regards to encoding confidence.
With any of the standard HTML Processor creation paths (
WP_HTML_Processor::create_fragment()andWP_HTML_Processor::create_full_parser()), the encoding is never set totentative. It is eitherirrelevant(on fragments) orcertainon full parsers. In both cases, only theUTF-8encoding is supported.This is an optimization to lift a necessary condition to the top level and avoid processing in the case we expect to encounter in almost every case.
Fragments follow this path to set
irrelevant:wordpress-develop/src/wp-includes/html-api/class-wp-html-processor.php
Line 319 in 1c8185e
wordpress-develop/src/wp-includes/html-api/class-wp-html-processor.php
Line 547 in 1c8185e
And full parsers set
certainhere:wordpress-develop/src/wp-includes/html-api/class-wp-html-processor.php
Line 345 in 1c8185e
Trac ticket:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.