Skip to content

Update getLastPostDate.php#9053

Open
pamprn09 wants to merge 3 commits intoWordPress:trunkfrom
pamprn09:63614-pre-get-lastpostdate-filter
Open

Update getLastPostDate.php#9053
pamprn09 wants to merge 3 commits intoWordPress:trunkfrom
pamprn09:63614-pre-get-lastpostdate-filter

Conversation

@pamprn09
Copy link

Add pre_get_lastpostdate filter to allow short-circuiting expensive queries.

This introduces a new filter, pre_get_lastpostdate, to allow plugins and advanced users to bypass the default database query in get_lastpostdate(), improving performance on large sites.

Trac ticket: #63614


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Posts: Add pre_get_lastpostdate filter to allow short-circuiting expensive queries.

This introduces a new filter, pre_get_lastpostdate, to allow plugins and advanced users
to bypass the default database query in get_lastpostdate(), improving performance on large sites.

Fixes #636914.
@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props pamprn.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

public function test_pre_get_lastpostdate_filter_short_circuits() {
$custom_date = gmdate( 'Y-m-d H:i:s' );
add_filter(
'pre_get_lastpostdate',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did these filter present in WP? Should it be get_lastpostdate?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I see, the ticket's aim is to add a new pre_get_lastpostdate filter, seems like the PR is missing the implementation, have updated trac with the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants