Canonical: Enhance redirection for post_format, pages and authors#9029
Canonical: Enhance redirection for post_format, pages and authors#9029SainathPoojary wants to merge 4 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
SainathPoojary
changed the title
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
SirLouen
left a comment
SirLouen
left a comment
There was a problem hiding this comment.
There are a couple review items proposed here
Reviewing the code, I'm not 100% confident this is the right way to proceed
Related #18475 and #15378
| @@ -62,6 +62,16 @@ public static function generate_shared_fixtures( WP_UnitTest_Factory $factory ) | |||
| ) | |||
| ); | |||
There was a problem hiding this comment.
This section is repeated twice
| $tax = get_taxonomy( 'post_format' ); | ||
| if ( ! is_admin() ) { | ||
| $qvs['post_type'] = $tax->object_type; | ||
| } |
There was a problem hiding this comment.
Not sure if this is the right way to proceed. Reference #18475
2 participants
Trac ticket: #20902
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.