Skip to content

Fix some build tool warnings #8701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
desrosj wants to merge 1 commit into from
Closed

Fix some build tool warnings #8701

desrosj wants to merge 1 commit into from

Conversation

@desrosj
Copy link
Member

@desrosj desrosj commented Apr 16, 2025 •
edited
Loading

There are a few errors happening when running npm run env:start:

The repository at "/var/www" does not have the correct ownership and git refuses to use it:

fatal: detected dubious ownership in repository at '/var/www'
To add an exception for this directory, call:

        git config --global --add safe.directory /var/www

Composer could not detect the root package (wordpress/wordpress) version, defaulting to '1.0.0'. See https://getcomposer.org/root-version

It appears that adding a version to the composer.json file fixes both of these errors.

Props @SirLouen for noticing this.

Trac ticket: https://core.trac.wordpress.org/ticket/63167

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@desrosj desrosj self-assigned this Apr 16, 2025
@github-actions
Copy link

github-actions bot commented Apr 16, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@desrosj desrosj force-pushed the try/fixing-tooling-errors branch from e499ab4 to 9f02e2f Compare April 16, 2025 14:31
@desrosj desrosj marked this pull request as ready for review April 16, 2025 14:37
@desrosj desrosj requested a review from johnbillion April 16, 2025 14:37
@github-actions
Copy link

github-actions bot commented Apr 16, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props desrosj, sirlouen, johnbillion.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

SirLouen
SirLouen approved these changes Apr 16, 2025
View reviewed changes
Copy link
Member

@SirLouen SirLouen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and I can confirm that the error message is not there anymore

johnbillion
johnbillion approved these changes Apr 16, 2025
View reviewed changes
Copy link
Member

@johnbillion johnbillion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pages that may need to be updated to mention updating the version number in composer.json:

@desrosj desrosj added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Apr 30, 2025
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Apr 30, 2025
@desrosj
Copy link
Member Author

desrosj commented Apr 30, 2025

Merged in https://core.trac.wordpress.org/changeset/60211.

@desrosj desrosj closed this Apr 30, 2025
@desrosj desrosj deleted the try/fixing-tooling-errors branch April 30, 2025 18:18
@desrosj
Copy link
Member Author

desrosj commented May 6, 2025

Closing the loop here.

The pages in the handbook listed above have been updated to include composer.json in their checklists. There are no default themes with a composer.json file currently, but I've also updated the page detailing steps for releasing default theme versions in case that comes up in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnbillion johnbillion johnbillion approved these changes

+1 more reviewer

@SirLouen SirLouen SirLouen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@desrosj desrosj

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@desrosj @johnbillion @SirLouen