-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Fix the fatal PHP error in _rest_array_intersect_key_recursive. #8440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the fatal PHP error in _rest_array_intersect_key_recursive. #8440
Conversation
…ch occurs because the first argument is null.
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The tests are failing but that is expected. I'll fix them in a couple of hours (need to go now). |
f078852 to
6141c3f
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Thanks @anton-vlasenko! This looks right to me. Could we add a unit test that specifically covers a HEAD request with |
Awesome! I'll add them today and let you know once they're ready. |
961f05b to
d39f249
Compare
d39f249 to
0b08957
Compare
|
@TimothyBJacobs I've added more tests in 0b08957. This took longer than I anticipated, but I've double checked they cover the regression. |
|
Sweet. Thank you! |
|
Thanks for working on this, @anton-vlasenko! @TimothyBJacobs, do you have time to commit this before Beta 2? |
It occurs because the first argument is null.
Trac ticket: https://core.trac.wordpress.org/ticket/56481
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.