Skip to content

Conversation

@anton-vlasenko
Copy link

@anton-vlasenko anton-vlasenko commented Mar 3, 2025

It occurs because the first argument is null.

Trac ticket: https://core.trac.wordpress.org/ticket/56481


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

…ch occurs because the first argument is null.
@github-actions
Copy link

github-actions bot commented Mar 3, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@anton-vlasenko
Copy link
Author

The tests are failing but that is expected. I'll fix them in a couple of hours (need to go now).

@anton-vlasenko anton-vlasenko force-pushed the fix/fix-head-requests-fatal-errors branch 2 times, most recently from f078852 to 6141c3f Compare March 3, 2025 18:20
@anton-vlasenko anton-vlasenko marked this pull request as ready for review March 3, 2025 18:22
@github-actions
Copy link

github-actions bot commented Mar 3, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props antonvlasenko, timothyblynjacobs, mamaduka.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@TimothyBJacobs
Copy link
Member

Thanks @anton-vlasenko! This looks right to me.

Could we add a unit test that specifically covers a HEAD request with ?_fields present?

@anton-vlasenko
Copy link
Author

Thanks @anton-vlasenko! This looks right to me.

Could we add a unit test that specifically covers a HEAD request with ?_fields present?

Awesome! I'll add them today and let you know once they're ready.

@anton-vlasenko anton-vlasenko force-pushed the fix/fix-head-requests-fatal-errors branch 3 times, most recently from 961f05b to d39f249 Compare March 6, 2025 23:12
@anton-vlasenko anton-vlasenko force-pushed the fix/fix-head-requests-fatal-errors branch from d39f249 to 0b08957 Compare March 6, 2025 23:14
@anton-vlasenko
Copy link
Author

@TimothyBJacobs I've added more tests in 0b08957. This took longer than I anticipated, but I've double checked they cover the regression.

@TimothyBJacobs
Copy link
Member

Sweet. Thank you!

@Mamaduka
Copy link
Member

Thanks for working on this, @anton-vlasenko!

@TimothyBJacobs, do you have time to commit this before Beta 2?

@github-actions
Copy link

github-actions bot commented Apr 8, 2025

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 60141
GitHub commit: bb55de7

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions bot closed this Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants