Skip to content

Block API: Add attribute-sourced block attributes on server #8000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
sirreal wants to merge 141 commits into
base: trunk
Choose a base branch
from
Draft

Block API: Add attribute-sourced block attributes on server #8000

sirreal wants to merge 141 commits into from

Conversation

@sirreal
Copy link
Member

@sirreal sirreal commented Dec 12, 2024 •
edited
Loading

This is a proof-of-concept.

Includes #7857

Related: #6388

Trac ticket:

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

sirreal added 30 commits December 5, 2024 22:52
@sirreal
WIP class skeleton
0e8c4fb
@sirreal
Document class
2d3d283
@sirreal
Do not support namespaced selectors
40222d3
@sirreal
Flesh out stuff
6092642
@sirreal
Starting to actually parse
3e3b2b2
@sirreal
Add ident tests
967557f
@sirreal
Fix ident non-ascii bug
2ec1db3
@sirreal
Use class after defined
ee2c7ce
@sirreal
Fix some char stuff
0f708ba
@sirreal
Improve tests
3cb455d
@sirreal
Housekeeping
5609e50
@sirreal
Require new file in WP
4f25bc2
@sirreal
Fix offset type
943293f
@sirreal
Add more tests and invalid tests
24c9744
@sirreal
Fix wrong offset var usage
a7c10b9
@sirreal
comment tweak
dd718b7
@sirreal
Implement codepoint escape with strspn
5884aca
@sirreal
Test with UPPER HEX
a9a077f
@sirreal
Add ID tests
5f53e0a
@sirreal
Improve tests
effbbbe
@sirreal
Add class selector tests
62ec5bb
@sirreal
Add class selector
153f009
@sirreal
Simplify id selector parse
fcc6401
@sirreal
Improve ident tests
21c67e5
@sirreal
Add type selector tests
728d798
@sirreal
Add docs and remove unreachable line
e1e8e09
@sirreal
Add type selector class
13ac3c1
@sirreal
Add attribute selector tests
a3c25e8
@sirreal
improve attr tests
ad5c600
@sirreal
Fix expectation argument order
6758704
@github-actions
Copy link

github-actions bot commented Dec 12, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@sirreal sirreal force-pushed the html-api/css-selector-block-attributes branch from 1ff0eb3 to 51343ec Compare December 13, 2024 19:08
@sirreal sirreal mentioned this pull request Dec 17, 2024
Draft
sirreal added 23 commits May 30, 2025 11:47
@sirreal
Merge branch 'trunk' into html-api/add-css-selector-parser
608caf3
@sirreal
Move parsing back to selector classes
1960dbf
@sirreal
Update tests for class parsing
5152295
@sirreal
Use whitepsace chars constant
6146eb1
@sirreal
parse_whitespace should be protected
8e90983
@sirreal
Update interface to abstract class require
16f6f1b
@sirreal
Document base class
9b67e69
@sirreal
Invert and comment confusing compound selector condition
325b94d
@sirreal
Use switch in compound selector parsing
6b09045
@sirreal
Fix up some todo-s
a0406c5
@sirreal
Make most selector constructors private
30e8533
@sirreal
Fix test class implementation of abstract class
6743c6c
@sirreal
Remove php 8+ ?static return types
f1eb083
@sirreal
Fix typo in Exception class name
10c469a
@sirreal
Remove ?static return type from test
ca73495
@sirreal
Merge branch 'html-api/add-css-selector-parser' into html-api/css-sel…
fa8d909 
…ector-block-attributes
@sirreal
Proof of concept adding attribute-sourced attrs.
1b8cfc9
@sirreal
Better implementation in parser
432e8bc
@sirreal
Data providers do not have ticket numbers
17072fd
@sirreal
remove "block_thing" function 😅
b12c595
@sirreal
Move to attributes calculation
fe5661a
@sirreal
Improve method name/signature, add tests
6e170f0
@sirreal
Include innerHTML in tests parsed block mocks
c3aa3e7
@sirreal sirreal force-pushed the html-api/css-selector-block-attributes branch from 5ea6a8e to c3aa3e7 Compare May 30, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sirreal