Skip to content

Global Styles: Fix Separator block color use #7927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
aaronrobertshaw wants to merge 4 commits into
base: trunk
Choose a base branch
from
Open

Global Styles: Fix Separator block color use #7927

aaronrobertshaw wants to merge 4 commits into from

Conversation

@aaronrobertshaw
Copy link

@aaronrobertshaw aaronrobertshaw commented Dec 2, 2024

Trac ticket: https://core.trac.wordpress.org/ticket/62624

This PR brings the changes from the following Gutenberg PRs to core:

Description

Removes the old fudging of style declarations for Separator block styles in favour of a more robust and consistent approach within the theme.json revolver.

The Separator block styles are now tweaked within the theme.json resolver's get_theme_data and get_user_data methods. This allows a subtle difference in handling based on the origin of the user data.

Theme data (from theme.json) containing a background color style for the Separator block will now use that as a fallback for color.text and border.color style paths. This allows the Separator block's different rendering approaches that rely on different CSS properties to use a consistent color.

User origin data, such as a color selection made in Global Styless, is now enforced across the different color paths. This means the user's selection is now honoured regardless of which block style, and therefore rendering method the Separator block employs.

A more detailed breakdown and discussion can be found on the GB PR: WordPress/gutenberg#67269

Test Instructions

  1. Activate a theme that defines color styles for the Separator block e.g. TT4 or TT5
  2. In the site editor, navigate to Styles > Blocks > Separator and apply a background color
  3. Save and confirm the correct color on the frontend.
    • If using TT5 for testing, note that the "Dots" block style requires the JS package updates for the editor to enforce the user selection.
  4. Reset Global Styles.
  5. Confirm that the Separator block styles coming from the theme.json are consistent with trunk.

Screenshots

Before

Screenshot 2024-11-25 at 6 47 36 pm

Note the overlaid color on top of the user-selected yellow in the above screenshot. This is due to the theme's styles not being overridden for non-background properties on trunk.

After

Screenshot 2024-11-25 at 6 48 31 pm

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@aaronrobertshaw aaronrobertshaw self-assigned this Dec 2, 2024
@aaronrobertshaw aaronrobertshaw mentioned this pull request Dec 2, 2024
Open
@github-actions
Copy link

github-actions bot commented Dec 2, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

mukeshpanchal27
mukeshpanchal27 reviewed Dec 2, 2024
View reviewed changes
@github-actions
Copy link

github-actions bot commented Dec 3, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props aaronrobertshaw, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@aaronrobertshaw aaronrobertshaw

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aaronrobertshaw @mukeshpanchal27