-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Add polyfill functions for PHP 8.4 array utilities #7879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Added `array_find` function to search an array for the first element that passes a given callback. - Added `array_find_key` function to search an array for the first key that passes a given callback. - Added `array_any` function to check if any element of an array passes a given callback. - Added `array_all` function to check if all elements of an array pass a given callback.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor WPCS suggestions
joemcgill
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These looks good to me and make sense as an addition to our compat functions.
array_findfunction to search an array for the first element that passes a given callback.array_find_keyfunction to search an array for the first key that passes a given callback.array_anyfunction to check if any element of an array passes a given callback.array_allfunction to check if all elements of an array pass a given callback.Trac ticket: https://core.trac.wordpress.org/ticket/62558
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.