Skip to content

Conversation

@tushar-addweb
Copy link

Scenarios Observed:

Text Does Not Overflow:
    When the application name (app_name parameter) contains paragraphs or spaces between words, the text is wrapped appropriately within the card area.
    Example URL:

http://localhost:8889/wp-admin/authorize-application.php?app_name=Contrary+to+popular+belief%2C+Lorem+Ipsum+is+not+simply+random+text.+It+has+roots+in+a+piece+of+classical+Latin+literature+from+45+BC%2C+making+it+over+2000+years+old.+Richard+McClintock%2C+a+Latin+professor+at+Hampden-Sydney+College+in+Virginia%2C+looked+up+one+of+the+more+obscure+Latin+words%2C+consectetur%2C+from+a+Lorem+Ipsum+passage%2C+and+going+through+the+cites+of+the+word+in+classical+literature%2C+discovered+the+undoubtable+source.

Screenshot: [Attached above showing proper wrapping.]

Text Overflows:

When the application name (app_name parameter) contains continuous text without any spaces or breaks, the text exceeds the boundaries of the card area and breaks the layout.
Example URL:

http://localhost:8889/wp-admin/authorize-application.php?app_name=asdflaksdklfjakldjfklajdfklasdkfjaklsdjjajknmmakalsjdkfjklajsdklfjaksdjfkasdjfkjsdfkaskdlfjaklsjdfklasjdfklajsdfkljakljsdklfjkljklajsdklfjklajsdfkljaklsdjfakljdfklajdfklasjdfklajsdfkljasdklfjaskldfjaslkdfjaskldjflaksjdfklasdjflkasjdflkajsdfasdkljfaklsjdfasjdfkaljsdfkladsf

Screenshot: https://prnt.sc/VxFBi60ZcnxC
https://prnt.sc/sc3mGyEpd05U
https://prnt.sc/tc2Y1rLFsm6R

Trac ticket: https://core.trac.wordpress.org/ticket/62064


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.
Clipboard - November 22, 2024 11_59 AM
Clipboard - November 22, 2024 11_56 AM
Clipboard - November 22, 2024 11_52 AM

@github-actions
Copy link

Hi @tushar-addweb! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

@github-actions
Copy link

github-actions bot commented Nov 22, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @pratik-londhe4, @rogerkinsta.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props tusharaddweb.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@pratik-londhe4
Copy link

Hi @tushar-addweb,
Thank you for the PR!
It seems the files might have been auto-formatted by your editor during saving. Could you please double-check this?

@rogerkinsta
Copy link

Trying to test the patch via the Playground link but playground errors out with this:

[09-Jul-2025 21:38:37 UTC] JavaScript Error: PHP.run() failed with exit code 255 and the following output: PHP Warning: ZipArchive::getStatusString(): Invalid or uninitialized Zip object in /internal/eval.php on line 23
PHP Fatal error: Uncaught Exception: Could not unzip file: in /internal/eval.php:23
Stack trace:
#0 /internal/eval.php(26): unzip('/tmp/file.zip', '/tmp/unzipped-w...', true)
#1 {main}
thrown in /internal/eval.php on line 23


Warning: ZipArchive::getStatusString(): Invalid or uninitialized Zip object in /internal/eval.php on line 23

Fatal error: Uncaught Exception: Could not unzip file: in /internal/eval.php:23 Stack trace: #0 /internal/eval.php(26): unzip('/tmp/file.zip', '/tmp/unzipped-w...', true) #1 {main} thrown in /internal/eval.php on line 23

Error: PHP.run() failed with exit code 255 and the following output: PHP Warning: ZipArchive::getStatusString(): Invalid or uninitialized Zip object in /internal/eval.php on line 23
PHP Fatal error: Uncaught Exception: Could not unzip file: in /internal/eval.php:23
Stack trace:
#0 /internal/eval.php(26): unzip('/tmp/file.zip', '/tmp/unzipped-w...', true)
#1 {main}
thrown in /internal/eval.php on line 23


Warning: ZipArchive::getStatusString(): Invalid or uninitialized Zip object in /internal/eval.php on line 23

Fatal error: Uncaught Exception: Could not unzip file: in /internal/eval.php:23 Stack trace: #0 /internal/eval.php(26): unzip('/tmp/file.zip', '/tmp/unzipped-w...', true) #1 {main} thrown in /internal/eval.php on line 23
at PHP.run (https://playground.wordpress.net/worker-thread-DAGie4cn.js:53:904)
at async unzipFile (https://playground.wordpress.net/worker-thread-DAGie4cn.js:96:1245)
at async unzipWordPress (https://playground.wordpress.net/worker-thread-DAGie4cn.js:816:76)
at async bootWordPress (https://playground.wordpress.net/worker-thread-DAGie4cn.js:476:558)
at async PlaygroundWorkerEndpoint.boot (https://playground.wordpress.net/worker-thread-DAGie4cn.js:1699:3322)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants