Skip to content

Conversation

@dd32
Copy link
Member

@dd32 dd32 commented Oct 29, 2024

Trac ticket: https://core.trac.wordpress.org/ticket/30465

Screenshot 2024-10-29 at 4 53 16 pm

This is partially reliant upon https://core.trac.wordpress.org/ticket/53333 / #1332 as the v1.2 updates API will currently return autoupdate data in a different manner. (This is a merge blocker)


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@dd32 dd32 self-assigned this Oct 29, 2024
@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props dd32.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@dd32 dd32 force-pushed the add/30465-plugins-closed-message branch from c597492 to 10911ae Compare October 29, 2024 07:38
dd32 added a commit to WordPress/wporg-experiments-plugin that referenced this pull request Oct 30, 2024
dd32 added a commit to WordPress/wporg-experiments-plugin that referenced this pull request Oct 30, 2024
@dd32 dd32 marked this pull request as draft October 31, 2024 07:16
@dd32
Copy link
Member Author

dd32 commented Oct 31, 2024

I have converted this to a draft PR for now, and pulled the changes (most of them anyway) into a plugin:

https://github.com/WordPress/wporg-experiments-plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant