Skip to content

Add type check for post password #7172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devansh016 wants to merge 2 commits into from
Closed

Add type check for post password #7172

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18963db
Add type check for post password
devansh016 Aug 9, 2024
680bb38
Update error code
devansh016 Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,6 +498,16 @@ public function get_item_permissions_check( $request ) {
}

if ( $post && ! empty( $request['password'] ) ) {

// Check if post password is string.
if ( ! is_string( $request['password'] ) ) {
return new WP_Error(
'rest_invalid_type',
__( 'Post password should be string.' ),
array( 'status' => 400 )
);
}

// Check post password, and return error if invalid.
if ( ! hash_equals( $post->post_password, $request['password'] ) ) {
return new WP_Error(
Expand Down