HTML API: Fix unclosed funky comment bug #7146
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A state change was missing when the input is too short to find a comment closer in an opened funky comment. This fixes a issue where `</#` does not correctly report incomplete input, but `</# ` does.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
pento
pushed a commit
that referenced
this pull request
Aug 6, 2024
…pause. A state change was missing in the Tag Processor when the input is too short to find a comment closer after an opened funky comment. This patch fixes a issue where `</#` does not correctly report incomplete input, but `</# ` does. Developed in #7146 Discussed in https://core.trac.wordpress.org/ticket/61831 Props: jonsurrell. Fixes #61831. git-svn-id: https://develop.svn.wordpress.org/trunk@58858 602fd350-edb4-49c9-b593-d223f7449a82
Member
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Aug 6, 2024
…pause. A state change was missing in the Tag Processor when the input is too short to find a comment closer after an opened funky comment. This patch fixes a issue where `</#` does not correctly report incomplete input, but `</# ` does. Developed in WordPress/wordpress-develop#7146 Discussed in https://core.trac.wordpress.org/ticket/61831 Props: jonsurrell. Fixes #61831. Built from https://develop.svn.wordpress.org/trunk@58858 git-svn-id: http://core.svn.wordpress.org/trunk@58254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to gilzow/wordpress-performance
that referenced
this pull request
Aug 6, 2024
…pause. A state change was missing in the Tag Processor when the input is too short to find a comment closer after an opened funky comment. This patch fixes a issue where `</#` does not correctly report incomplete input, but `</# ` does. Developed in WordPress/wordpress-develop#7146 Discussed in https://core.trac.wordpress.org/ticket/61831 Props: jonsurrell. Fixes #61831. Built from https://develop.svn.wordpress.org/trunk@58858 git-svn-id: https://core.svn.wordpress.org/trunk@58254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
aslamdoctor
pushed a commit
to aslamdoctor/wordpress-develop
that referenced
this pull request
Dec 28, 2024
…pause. A state change was missing in the Tag Processor when the input is too short to find a comment closer after an opened funky comment. This patch fixes a issue where `</#` does not correctly report incomplete input, but `</# ` does. Developed in WordPress#7146 Discussed in https://core.trac.wordpress.org/ticket/61831 Props: jonsurrell. Fixes #61831. git-svn-id: https://develop.svn.wordpress.org/trunk@58858 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
</#is not treated as incomplete input but</#is. Both should be incomplete input.The HTML Tag Processor may report ::paused_at_incomplete_token() === true correctly when the HTML ends in an open "funky comment."
The HTML </# should be handled the same as </# , in both cases a funky comment has been opened but no closer is found before the HTML document ends. Both cases should both be treated as incomplete input, however the former case (with no trailing space) does not report an incomplete token.
Trac ticket: https://core.trac.wordpress.org/ticket/61831
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.