Pages: cast $max_depth and $depth to int on class Walker#7091
Pages: cast $max_depth and $depth to int on class Walker#7091freibergergarcia wants to merge 2 commits into
Conversation
Cast $max_depth and $depth to integer on the class Walker (class-wp-walker) so it complains with strict comparisons. Fixes: https://core.trac.wordpress.org/ticket/61749
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
Thanks for the PR! Merged in r58812. |
Cast $max_depth and $depth to integer on class Walker (class-wp-walker), so it's compliant with strict comparisons.
Trac ticket: https://core.trac.wordpress.org/ticket/61749
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.