Section Styles: Fix ref values within block style variations#6989
Closed
aaronrobertshaw wants to merge 2 commits intoWordPress:trunkfrom
Closed
Section Styles: Fix ref values within block style variations#6989aaronrobertshaw wants to merge 2 commits intoWordPress:trunkfrom
aaronrobertshaw wants to merge 2 commits intoWordPress:trunkfrom
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
andrewserong
approved these changes
Jul 8, 2024
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
This is testing nicely for me, just as WordPress/gutenberg#63172 does on the site frontend. It'll need the JS packages update from that PR before it'll work in the site editor, but for the PHP changes this change looks good to land from my perspective!
ramonjd
approved these changes
Jul 9, 2024
Member
ramonjd
left a comment
ramonjd
left a comment
There was a problem hiding this comment.
I tested along the same lines as WordPress/gutenberg#63172
On the frontend, the values are being resolved from the theme.json tree as expected. 👍🏻
Co-authored-by: Ramon <[email protected]>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Jul 9, 2024
This is fixed by preloading the styles. Fixes #61589. Fixes WordPress/wordpress-develop#6989. See WordPress/gutenberg#63172. Props aaronrobertshaw, andrewserong, ramonopoly. Built from https://develop.svn.wordpress.org/trunk@58690 git-svn-id: http://core.svn.wordpress.org/trunk@58092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to gilzow/wordpress-performance
that referenced
this pull request
Jul 9, 2024
This is fixed by preloading the styles. Fixes #61589. Fixes WordPress/wordpress-develop#6989. See WordPress/gutenberg#63172. Props aaronrobertshaw, andrewserong, ramonopoly. Built from https://develop.svn.wordpress.org/trunk@58690 git-svn-id: https://core.svn.wordpress.org/trunk@58092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Jul 9, 2024
Fixes #61589. Fixes WordPress/wordpress-develop#6989. See WordPress/gutenberg#63172. Props aaronrobertshaw, andrewserong, ramonopoly. Built from https://develop.svn.wordpress.org/trunk@58691 git-svn-id: http://core.svn.wordpress.org/trunk@58093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to gilzow/wordpress-performance
that referenced
this pull request
Jul 9, 2024
Fixes #61589. Fixes WordPress/wordpress-develop#6989. See WordPress/gutenberg#63172. Props aaronrobertshaw, andrewserong, ramonopoly. Built from https://develop.svn.wordpress.org/trunk@58691 git-svn-id: https://core.svn.wordpress.org/trunk@58093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Debarghya-Banerjee
pushed a commit
to Debarghya-Banerjee/wordpress-develop
that referenced
this pull request
Jul 18, 2024
This is fixed by preloading the styles. Fixes #61589. Fixes WordPress#6989. See WordPress/gutenberg#63172. Props aaronrobertshaw, andrewserong, ramonopoly. git-svn-id: https://develop.svn.wordpress.org/trunk@58690 602fd350-edb4-49c9-b593-d223f7449a82
Debarghya-Banerjee
pushed a commit
to Debarghya-Banerjee/wordpress-develop
that referenced
this pull request
Jul 18, 2024
Fixes #61589. Fixes WordPress#6989. See WordPress/gutenberg#63172. Props aaronrobertshaw, andrewserong, ramonopoly. git-svn-id: https://develop.svn.wordpress.org/trunk@58691 602fd350-edb4-49c9-b593-d223f7449a82
aslamdoctor
pushed a commit
to aslamdoctor/wordpress-develop
that referenced
this pull request
Dec 28, 2024
This is fixed by preloading the styles. Fixes #61589. Fixes WordPress#6989. See WordPress/gutenberg#63172. Props aaronrobertshaw, andrewserong, ramonopoly. git-svn-id: https://develop.svn.wordpress.org/trunk@58690 602fd350-edb4-49c9-b593-d223f7449a82
aslamdoctor
pushed a commit
to aslamdoctor/wordpress-develop
that referenced
this pull request
Dec 28, 2024
Fixes #61589. Fixes WordPress#6989. See WordPress/gutenberg#63172. Props aaronrobertshaw, andrewserong, ramonopoly. git-svn-id: https://develop.svn.wordpress.org/trunk@58691 602fd350-edb4-49c9-b593-d223f7449a82
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR backports the fix from:
This restores the ability to reference style values from elsewhere within theme.json for block style variations.
Trac ticket: https://core.trac.wordpress.org/ticket/61589#ticket
Test Instructions
Example theme.json snippet
{ "styles": { "elements": { "button": { "border": { "color": "transparent", "radius": "0.25em", "style": "solid", "width": "1px" }, "color": { "background": "var(--wp--preset--color--accent)", "text": "var(--wp--preset--color--base)" }, "spacing": { "padding": { "bottom": "0.5em", "left": "1.25em", "right": "1.25em", "top": "0.5em" } } } }, "blocks": { "core/button": { "border": { "color": { "ref": "styles.elements.button.border.color" }, "radius": { "ref": "styles.elements.button.border.radius" }, "style": { "ref": "styles.elements.button.border.style" }, "width": { "ref": "styles.elements.button.border.width" } }, "color": { "background": { "ref": "styles.elements.button.color.background" }, "text": { "ref": "styles.elements.button.color.text" } }, "spacing": { "padding": { "bottom": { "ref": "styles.elements.button.spacing.padding.bottom" }, "left": { "ref": "styles.elements.button.spacing.padding.left" }, "right": { "ref": "styles.elements.button.spacing.padding.right" }, "top": { "ref": "styles.elements.button.spacing.padding.top" } } }, "variations": { "outline": { "border": { "color": "currentColor", "width": { "ref": "styles.elements.button.border.width" } }, "color": { "text": { "ref": "styles.elements.button.color.background" } }, "spacing": { "padding": { "bottom": { "ref": "styles.elements.button.spacing.padding.bottom" }, "left": { "ref": "styles.elements.button.spacing.padding.left" }, "right": { "ref": "styles.elements.button.spacing.padding.right" }, "top": { "ref": "styles.elements.button.spacing.padding.top" }, } } } } } } } }Screenshots or screencast
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.