Skip to content

Add handling for indexed-color image type in WP Image Editor#6455

Open
pbearne wants to merge 14 commits intoWordPress:trunkfrom
pbearne:36477-keep-color-depth
Open

Add handling for indexed-color image type in WP Image Editor#6455
pbearne wants to merge 14 commits intoWordPress:trunkfrom
pbearne:36477-keep-color-depth

Conversation

@pbearne
Copy link

@pbearne pbearne commented Apr 26, 2024

A new functionality has been added to the WP Image Editor class to check if an image is indexed-color encoded. This property is considered when saving a resized image to preserve its original image type. This reduces instances where the resized image filesize would end up larger than the original. A test to verify smaller file size for resized images has also been included.

Trac ticket: https://core.trac.wordpress.org/ticket/36477

A new functionality has been added to the WP Image Editor class to check if an image is indexed-color encoded. This property is considered when saving a resized image to preserve its original image type. This reduces instances where the resized image filesize would end up larger than the original. A test to verify smaller file size for resized images has also been included.
@github-actions
Copy link

github-actions bot commented Apr 26, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @paul.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props pbearne, nosilver4u, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

A new functionality has been added to the WP Image Editor class to check if an image is indexed-color encoded. This property is considered when saving a resized image to preserve its original image type. This reduces instances where the resized image filesize would end up larger than the original. A test to verify smaller file size for resized images has also been included.
@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

pbearne and others added 12 commits April 29, 2024 11:34
The image resizing test in `editorImagick.php` was refactored to utilize a data provider. This allows for a more comprehensive testing with a variety of 16-bit image files. Now, multiple test files including `17-c3-duplicate-entries.png`, `cloudflare-status.png`, and more are considered in the test case.
The buffer only seemed to help on the image that was getting converted to grayscale. But once the grayscale issue was fixed, the buffer wasn't having the desired effect on quality.
…to 36477-keep-color-depth

# Conflicts:
#	src/wp-includes/class-wp-image-editor-imagick.php
Optimized the png color depth with valid png unit test by adding the expected_encoded parameter to match the expected result. Additionally, debugging code has been removed from WP_Image_Editor_Imagick, improving its readability and performance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments