Fix wrong file size when scaling images.#6406
Conversation
|
Hi @pls78! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
peterwilsoncc
left a comment
peterwilsoncc
left a comment
There was a problem hiding this comment.
There's a minor bug in the restore functionality, noted inline.
|
@pls78 I took the liberty of pushing some code to your branch:
|
2 participants
What
This PR fixes the wrong file size displayed in the media library when a user resizes an image. At the same time, if the user decides to revert the changes made to the image, this PR makes possible to revert to the original file size.
Why
This PR solves the issue described in the following Trac ticket: https://core.trac.wordpress.org/ticket/59684
How
wp_save_imagefunction I collect the array returned bywp_save_image_file, which contains the file size of the resized image, and add it to the attachment metadata array as$meta['filesize']$backup_sizesarray, along with the image filename and dimensionswp_restore_imagefunction I then read back from$backup_sizesthe original file size and restore it when the user reverts back to the original sizeTest instructions
Test the scale image case
Media->Add New Media Fileand upload an imageEdit ImageScaleand specify the new width and heightTest the restore original image case
Edit ImageRESTORE ORIGINAL IMAGE->Restore ImageThis Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.