Skip to content

Conversation

@desrosj
Copy link
Member

@desrosj desrosj commented Jan 24, 2024

Trac ticket: https://core.trac.wordpress.org/ticket/59657.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@mukeshpanchal27
Copy link
Member

@desrosj Do we need package-lock.json changes?

@desrosj
Copy link
Member Author

desrosj commented Jan 24, 2024

@mukeshpanchal27 In this case, yes. The package that needs to be updated is not a direct dependency, so it's only defined within the lock file.

Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Everything looks good. @sirreal, was it necessary for anything related to bundling Interactivity code?

@sirreal
Copy link
Member

sirreal commented Jan 26, 2024

Yes, we hit problems and cherry-picked the package-lock changes here to unblock this work: #5922 (comment)

When this PR lands that removes a blocker 👍

@desrosj
Copy link
Member Author

desrosj commented Jan 26, 2024

I'm going to commit this since this blocks other work and is a reasonable change to make. But I do have some concerns around the frequent churn related to these updates has caused recently. I documented these changes on the Trac ticket.

@desrosj
Copy link
Member Author

desrosj commented Jan 26, 2024

@desrosj desrosj closed this Jan 26, 2024
@desrosj desrosj deleted the update/caniuse-data branch January 26, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants