fix(Codespaces): Fixes broken Codespaces Environment & Adds Working Local Dev Container Support #5832
Conversation
|
Hi @timnolte! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
timnolte
force-pushed
the
fix/codespaces-devcontainer
branch
from
50d2ea1 to
c3ad43b
Compare
timnolte
force-pushed
the
fix/codespaces-devcontainer
branch
3 times, most recently
from
667048b to
2ff913f
Compare
…ocal Dev Container Support - Updates the Dev Container setup to use a pre-built Dev Container image optimized for WordPress builds. - Updates the Dev Container setup to allow for proper testing of WordPress Core. - Reorganizes some of the Dev Container setup as features. - Updates the Dev Container to properly support using Xdebug without impacting PHPUnit testing. Trac ticket: https://core.trac.wordpress.org/ticket/60144
timnolte
force-pushed
the
fix/codespaces-devcontainer
branch
from
2ff913f to
7d895a5
Compare
kamranzafar4343
left a comment
kamranzafar4343
left a comment
There was a problem hiding this comment.
looks fine to me, i hope it would be merged
| @@ -1,4 +1,4 @@ | |||
| # gitignore file for WordPress Core | |||
| /bin/bash: line 1: /: Is a directory | |||
There was a problem hiding this comment.
Hmm, interesting, that must have been some sort of copy/paste error. I'll get that fixed.
| services: | ||
| app: | ||
| image: wordpress | ||
| image: ghcr.io/ndigitals/wp-dev-container:php-8.2-node-20 |
There was a problem hiding this comment.
Note sure we'd want to use any third-pary image here that's not maintained by WP or Docker 🤔
There was a problem hiding this comment.
There is no prebuilt Docker container that exists that includes everything in this prebuilt Dev Container image that is also built for multi architecture. I have spent time to specifically build this image based off of the WP Dev Docker image. The entire source for it is open for review as well. If you want to force Devs that want to use the Dev Container on Apple chips to have slow subpar, or potentially broken, experiences then you can use the WP Dev image, however it's also going to require significantly longer startup time for Devs as well.
There was a problem hiding this comment.
What would need to added to the WordPress Dev contains in order to support this?
|
Bump |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @kamranzafar4343, @anoblet. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
I'm closing this PR, I no longer intend to contribute to WordPress. |
5 participants
Trac ticket: https://core.trac.wordpress.org/ticket/60144
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.