Simplify initialization of WP_Block_Parser::$empty_attrs#5049
Closed
dlh01 wants to merge 1 commit intoWordPress:trunkfrom
Closed
Simplify initialization of WP_Block_Parser::$empty_attrs#5049dlh01 wants to merge 1 commit intoWordPress:trunkfrom
WP_Block_Parser::$empty_attrs#5049dlh01 wants to merge 1 commit intoWordPress:trunkfrom
Conversation
Member
|
@dlh01 I like this change. But I would remove the changes to docs. We can do this elsewhere and it does not need to block this change. |
Author
|
@spacedmonkey OK, I removed the docs changes and will submit them separately. |
Member
|
This change was applied to Gutenberg in WordPress/gutenberg#54424. Should this be done separately or come through via an update to the Gutenberg packages? cc: @mcsf |
Member
|
Fixed upstream. |
86 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/59168