Add a check for wp_get_current_user to current_user_can #4959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
reviewed
Aug 8, 2023
| */ | ||
| function current_user_can( $capability, ...$args ) { | ||
| if ( ! function_exists( 'wp_get_current_user' ) ) { | ||
| return false; |
There was a problem hiding this comment.
This should not return false because it means user can't and maybe user can but we don't know yet if they can because we can't wp_get_current_user. 😆 It should return an error that can be used so that the extender or core calls current_user_can correctly.
Contributor
Author
Contributor
Author
|
Closing in favour of #5028 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix WordPress/gutenberg#53284.
The problem is that it's possible to call
current_user_canbeforewp_get_current_userhas been defined. We could guard against this by checking whetherwp_get_current_useris defined before callingcurrent_user_caneach time, but adding the check here seems simpler.I'm not sure if it makes sense to return false in this case, maybe we should return an error instead?
Fixes https://core.trac.wordpress.org/ticket/59000